Deprecate protocols field in google_network_services_agent_gateway#17932
Conversation
This field is being deprecated in the API and will be removed in a future major release. This change marks the field as deprecated in Magic Modules and removes its usage from examples and tests.
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 115e4d8: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_network_services_agent_gateway" "primary" {
protocols = # value needed
}
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @ericlin0101, @malhotrasagar2212 VCR tests complete for 115e4d8! |
malhotrasagar2212
left a comment
There was a problem hiding this comment.
Thanks for the PR, since we are deprecating the protocol field, Could we keep it in one of the tests to satisfy the CI missing test report step?
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 2dff0c5: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @ericlin0101, @malhotrasagar2212 VCR tests complete for 2dff0c5! |
|
Thanks for the review! I've kept the field in some of the tests. |
dcd4453
This field is being deprecated in the API and will be removed in a future major release. This change marks the field as deprecated in Magic Modules and removes its usage from examples and tests.