Skip to content

Deprecate protocols field in google_network_services_agent_gateway#17932

Merged
rileykarson merged 2 commits into
GoogleCloudPlatform:mainfrom
ericlin0101:depreciate-protocols
Jun 11, 2026
Merged

Deprecate protocols field in google_network_services_agent_gateway#17932
rileykarson merged 2 commits into
GoogleCloudPlatform:mainfrom
ericlin0101:depreciate-protocols

Conversation

@ericlin0101

@ericlin0101 ericlin0101 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

This field is being deprecated in the API and will be removed in a future major release. This change marks the field as deprecated in Magic Modules and removes its usage from examples and tests.

networkservices: deprecated `protocols` on `google_network_services_agent_gateway`

This field is being deprecated in the API and will be removed in a future
major release. This change marks the field as deprecated in Magic Modules
and removes its usage from examples and tests.
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

modular-magician commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 115e4d8:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 7 insertions(+), 10 deletions(-)
google-beta provider View Diff 4 files changed, 17 insertions(+), 25 deletions(-)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_services_agent_gateway (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_services_agent_gateway" "primary" {
  protocols = # value needed
}

Test report

Analytics

Total Tests Passed Skipped Affected
101 95 6 0
Affected Service Packages
  • networkservices

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@ericlin0101, @malhotrasagar2212 VCR tests complete for 115e4d8!

@malhotrasagar2212 malhotrasagar2212 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, since we are deprecating the protocol field, Could we keep it in one of the tests to satisfy the CI missing test report step?

@modular-magician

modular-magician commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 2dff0c5:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 7 insertions(+), 9 deletions(-)
google-beta provider View Diff 4 files changed, 18 insertions(+), 23 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
101 95 6 0
Affected Service Packages
  • networkservices

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@ericlin0101, @malhotrasagar2212 VCR tests complete for 2dff0c5!

@ericlin0101

Copy link
Copy Markdown
Contributor Author

Thanks for the review! I've kept the field in some of the tests.

@rileykarson rileykarson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rileykarson rileykarson added this pull request to the merge queue Jun 11, 2026
Merged via the queue into GoogleCloudPlatform:main with commit dcd4453 Jun 11, 2026
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants