Skip to content

Add node_config.taint_config field#17936

Open
drjackild wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
drjackild:node-config-taint-config-field
Open

Add node_config.taint_config field#17936
drjackild wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
drjackild:node-config-taint-config-field

Conversation

@drjackild

Copy link
Copy Markdown

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

container: added `taint_config` block to `google_container_cluster` and `google_container_node_pool`

@github-actions github-actions Bot requested a review from hao-nan-li June 11, 2026 17:46
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

modular-magician commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 510bfd3:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 300 insertions(+)
google-beta provider View Diff 5 files changed, 300 insertions(+)
terraform-google-conversion View Diff 2 files changed, 6 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (567 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_pool {
    node_config {
      taint_config {
        architecture_taint_behavior = # value needed
      }
    }
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_container_cluster
    • Expected Document Path: /website/docs/r/container_cluster.html.markdown
    • Fields: [node_pool.node_config.taint_config node_pool.node_config.taint_config.architecture_taint_behavior]
  • google_container_node_pool
    • Expected Document Path: /website/docs/r/container_node_pool.html.markdown
    • Fields: [node_config.taint_config node_config.taint_config.architecture_taint_behavior]

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

  • container

Please fix the compilation errors to complete your PR.

View the build log

@drjackild, @hao-nan-li VCR tests complete for 510bfd3!

@drjackild drjackild force-pushed the node-config-taint-config-field branch from 510bfd3 to b77520d Compare June 11, 2026 18:00
@modular-magician

modular-magician commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b77520d:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 7 files changed, 306 insertions(+)
google-beta provider View Diff 7 files changed, 306 insertions(+)
terraform-google-conversion View Diff 2 files changed, 6 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (567 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_pool {
    node_config {
      taint_config {
        architecture_taint_behavior = # value needed
      }
    }
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_container_cluster
    • Expected Document Path: /website/docs/r/container_cluster.html.markdown
    • Fields: [node_pool.node_config.taint_config node_pool.node_config.taint_config.architecture_taint_behavior]
  • google_container_node_pool
    • Expected Document Path: /website/docs/r/container_node_pool.html.markdown
    • Fields: [node_config.taint_config node_config.taint_config.architecture_taint_behavior]

Test report

Analytics

Total Tests Passed Skipped Affected
297 279 15 3
Affected Service Packages
  • container

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccContainerCluster_withTaintConfig
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccContainerNodePool_withTaintConfig

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccContainerCluster_withTaintConfig
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log - TestAccContainerNodePool_withTaintConfig

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@drjackild, @hao-nan-li VCR tests complete for b77520d!

@drjackild drjackild force-pushed the node-config-taint-config-field branch from b77520d to c92dd82 Compare June 11, 2026 18:12
@modular-magician

modular-magician commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit c92dd82:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 7 files changed, 305 insertions(+)
google-beta provider View Diff 7 files changed, 305 insertions(+)
terraform-google-conversion View Diff 2 files changed, 6 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (567 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_pool {
    node_config {
      taint_config {
        architecture_taint_behavior = # value needed
      }
    }
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_container_cluster
    • Expected Document Path: /website/docs/r/container_cluster.html.markdown
    • Fields: [node_pool.node_config.taint_config node_pool.node_config.taint_config.architecture_taint_behavior]
  • google_container_node_pool
    • Expected Document Path: /website/docs/r/container_node_pool.html.markdown
    • Fields: [node_config.taint_config node_config.taint_config.architecture_taint_behavior]

Test report

Analytics

Total Tests Passed Skipped Affected
297 280 15 2
Affected Service Packages
  • container

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccContainerNodePool_withTaintConfig

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccContainerNodePool_withTaintConfig
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@drjackild, @hao-nan-li VCR tests complete for c92dd82!

@drjackild drjackild force-pushed the node-config-taint-config-field branch from c92dd82 to d31deab Compare June 11, 2026 19:08
@modular-magician

modular-magician commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d31deab:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 7 files changed, 397 insertions(+)
google-beta provider View Diff 7 files changed, 397 insertions(+)
terraform-google-conversion View Diff 2 files changed, 9 insertions(+)

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_container_cluster
    • Expected Document Path: /website/docs/r/container_cluster.html.markdown
    • Fields: [node_pool.node_config.taint_config]
  • google_container_node_pool
    • Expected Document Path: /website/docs/r/container_node_pool.html.markdown
    • Fields: [node_config.taint_config]

Test report

Analytics

Total Tests Passed Skipped Affected
298 281 15 2
Affected Service Packages
  • container

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccContainerCluster_withNodePoolTaintConfig
  • TestAccContainerNodePool_withHostMaintenancePolicy

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccContainerCluster_withNodePoolTaintConfig
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@drjackild, @hao-nan-li VCR tests complete for d31deab!

@drjackild drjackild force-pushed the node-config-taint-config-field branch from d31deab to 1665b99 Compare June 11, 2026 19:28
@modular-magician

modular-magician commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 1665b99:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 7 files changed, 415 insertions(+), 4 deletions(-)
google-beta provider View Diff 7 files changed, 415 insertions(+), 4 deletions(-)
terraform-google-conversion View Diff 2 files changed, 9 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
298 281 15 2
Affected Service Packages
  • container

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccContainerCluster_withNodePoolTaintConfig
  • TestAccContainerNodePool_withHostMaintenancePolicy

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccContainerCluster_withNodePoolTaintConfig
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@drjackild, @hao-nan-li VCR tests complete for 1665b99!

@drjackild drjackild force-pushed the node-config-taint-config-field branch from 1665b99 to 430676a Compare June 11, 2026 20:56
@modular-magician

modular-magician commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 430676a:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 7 files changed, 424 insertions(+), 4 deletions(-)
google-beta provider View Diff 7 files changed, 424 insertions(+), 4 deletions(-)
terraform-google-conversion View Diff 2 files changed, 12 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
299 281 15 3
Affected Service Packages
  • container

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccContainerCluster_withNodePoolTaintConfig
  • TestAccContainerCluster_withNodePoolTaintConfig_none
  • TestAccContainerNodePool_withHostMaintenancePolicy

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccContainerCluster_withNodePoolTaintConfig
❌ Error · Log - TestAccContainerCluster_withNodePoolTaintConfig_none
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@drjackild, @hao-nan-li VCR tests complete for 430676a!

@drjackild drjackild force-pushed the node-config-taint-config-field branch from 430676a to 4369ee3 Compare June 11, 2026 22:10
@modular-magician

modular-magician commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 4369ee3:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 7 files changed, 423 insertions(+), 4 deletions(-)
google-beta provider View Diff 7 files changed, 423 insertions(+), 4 deletions(-)
terraform-google-conversion View Diff 2 files changed, 12 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
301 283 15 3
Affected Service Packages
  • container

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccContainerCluster_withNodePoolTaintConfig
  • TestAccContainerCluster_withNodePoolTaintConfig_none
  • TestAccContainerNodePool_withHostMaintenancePolicy

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccContainerCluster_withNodePoolTaintConfig
✅ Log TestAccContainerCluster_withNodePoolTaintConfig_none
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@drjackild, @hao-nan-li VCR tests complete for 4369ee3!

@drjackild

drjackild commented Jun 11, 2026

Copy link
Copy Markdown
Author

Hi @hao-nan-li ! The failing test is unrelated to my changes and the reason it's failing is actually stockout in us-central1-a:

Error: Error waiting for creating GKE cluster: Google Compute Engine: Not all instances running in IGM after 35m8.771309432s. Expected 1, running 0, transitioning 1. 

Current errors: [GCE_STOCKOUT]: Instance 'gke-tf-test-cluster-qn7u-default-pool-d4145cae-b0qh' creation failed: The zone 'projects/ci-test-project-188019/zones/us-central1-a' does not have enough resources available to fulfill the request. '(resource type:compute)'.

As for the terraform-google-conversion-test-integration - the failing stage is also showing unrelated to these changes failure:

--- FAIL: TestAccContainerCluster (0.02s)
     --- FAIL: TestAccContainerCluster/TestAccContainerCluster_withSlurmOperatorConfig (12.53s)
         --- FAIL: TestAccContainerCluster/TestAccContainerCluster_withSlurmOperatorConfig/step1 (0.23s)
             assert_test_files.go:117: TestAccContainerCluster_withSlurmOperatorConfig_step1: Starting test with retry logic.
             assert_test_files.go:92: TestAccContainerCluster_withSlurmOperatorConfig_step1: Test for the primary resource google_container_cluster.with_slurm_config begins.
             assert_test_files.go:138: TestAccContainerCluster_withSlurmOperatorConfig_step1: Failed after 5 attempts. First real error: retryable: missing fields: [addons_config.slurm_operator_config.enabled]
         logger.go:146: 2026-06-11T22:26:44.561Z	INFO	Retrieving ancestry from resource (type=container.googleapis.com/Cluster)
         logger.go:146: 2026-06-11T22:26:51.344Z	INFO	Retrieving ancestry from resource (type=container.googleapis.com/Cluster)
         --- FAIL: TestAccContainerCluster/TestAccContainerCluster_withSlurmOperatorConfig/step5 (0.24s)
             assert_test_files.go:117: TestAccContainerCluster_withSlurmOperatorConfig_step5: Starting test with retry logic.
             assert_test_files.go:92: TestAccContainerCluster_withSlurmOperatorConfig_step5: Test for the primary resource google_container_cluster.with_slurm_config begins.
            assert_test_files.go:138: TestAccContainerCluster_withSlurmOperatorConfig_step5: Failed after 5 attempts. First real error: retryable: missing fields: [addons_config.slurm_operator_config.enabled]

Thank you for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants