Add node_config.taint_config field#17936
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 510bfd3: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_container_cluster" "primary" {
node_pool {
node_config {
taint_config {
architecture_taint_behavior = # value needed
}
}
}
}
Missing doc report (experimental)The following resources have fields missing in documents.
Step 1: Replaying Mode Caution Build Failure during VCR tests 🔴 REPLAYING mode: The following packages failed to build:
Please fix the compilation errors to complete your PR. View the build log @drjackild, @hao-nan-li VCR tests complete for 510bfd3! |
510bfd3 to
b77520d
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b77520d: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_container_cluster" "primary" {
node_pool {
node_config {
taint_config {
architecture_taint_behavior = # value needed
}
}
}
}
Missing doc report (experimental)The following resources have fields missing in documents.
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @drjackild, @hao-nan-li VCR tests complete for b77520d! |
b77520d to
c92dd82
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit c92dd82: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_container_cluster" "primary" {
node_pool {
node_config {
taint_config {
architecture_taint_behavior = # value needed
}
}
}
}
Missing doc report (experimental)The following resources have fields missing in documents.
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @drjackild, @hao-nan-li VCR tests complete for c92dd82! |
c92dd82 to
d31deab
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d31deab: Diff reportYour PR generated the following diffs in downstream repositories:
Missing doc report (experimental)The following resources have fields missing in documents.
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @drjackild, @hao-nan-li VCR tests complete for d31deab! |
d31deab to
1665b99
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 1665b99: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @drjackild, @hao-nan-li VCR tests complete for 1665b99! |
1665b99 to
430676a
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 430676a: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @drjackild, @hao-nan-li VCR tests complete for 430676a! |
430676a to
4369ee3
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 4369ee3: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @drjackild, @hao-nan-li VCR tests complete for 4369ee3! |
|
Hi @hao-nan-li ! The failing test is unrelated to my changes and the reason it's failing is actually stockout in us-central1-a: Error: Error waiting for creating GKE cluster: Google Compute Engine: Not all instances running in IGM after 35m8.771309432s. Expected 1, running 0, transitioning 1.
Current errors: [GCE_STOCKOUT]: Instance 'gke-tf-test-cluster-qn7u-default-pool-d4145cae-b0qh' creation failed: The zone 'projects/ci-test-project-188019/zones/us-central1-a' does not have enough resources available to fulfill the request. '(resource type:compute)'.As for the --- FAIL: TestAccContainerCluster (0.02s)
--- FAIL: TestAccContainerCluster/TestAccContainerCluster_withSlurmOperatorConfig (12.53s)
--- FAIL: TestAccContainerCluster/TestAccContainerCluster_withSlurmOperatorConfig/step1 (0.23s)
assert_test_files.go:117: TestAccContainerCluster_withSlurmOperatorConfig_step1: Starting test with retry logic.
assert_test_files.go:92: TestAccContainerCluster_withSlurmOperatorConfig_step1: Test for the primary resource google_container_cluster.with_slurm_config begins.
assert_test_files.go:138: TestAccContainerCluster_withSlurmOperatorConfig_step1: Failed after 5 attempts. First real error: retryable: missing fields: [addons_config.slurm_operator_config.enabled]
logger.go:146: 2026-06-11T22:26:44.561Z INFO Retrieving ancestry from resource (type=container.googleapis.com/Cluster)
logger.go:146: 2026-06-11T22:26:51.344Z INFO Retrieving ancestry from resource (type=container.googleapis.com/Cluster)
--- FAIL: TestAccContainerCluster/TestAccContainerCluster_withSlurmOperatorConfig/step5 (0.24s)
assert_test_files.go:117: TestAccContainerCluster_withSlurmOperatorConfig_step5: Starting test with retry logic.
assert_test_files.go:92: TestAccContainerCluster_withSlurmOperatorConfig_step5: Test for the primary resource google_container_cluster.with_slurm_config begins.
assert_test_files.go:138: TestAccContainerCluster_withSlurmOperatorConfig_step5: Failed after 5 attempts. First real error: retryable: missing fields: [addons_config.slurm_operator_config.enabled]Thank you for your review! |
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.