Skip to content

feat: Add resource identity to google_secret_manager_secret_version - #18451

Open
vr-ibm wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
vr-ibm:feat/secret-manager-secret-version-identity-clean
Open

feat: Add resource identity to google_secret_manager_secret_version#18451
vr-ibm wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
vr-ibm:feat/secret-manager-secret-version-identity-clean

Conversation

@vr-ibm

@vr-ibm vr-ibm commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Adds resource identity support to google_secret_manager_secret_version by:

  • Removing exclude_identity_generation: true from SecretVersion.yaml to re-enable MMv1 identity generation
  • Updating the custom import template to call SetResourceIdentityAttributes with project, secret, and version parsed from the version name

The custom import was previously excluded from identity generation due to its regex-based name parsing. The import template now sets identity attributes directly from the already-parsed versionRegex match groups after import.

This is a prerequisite for adding a google_secret_manager_secret_version list resource.

resource/`google_secret_manager_secret_version`: Added resource identity support

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/secretmanager and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jul 29, 2026
@modular-magician

modular-magician commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e5675ff:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 97 insertions(+)
google-beta provider View Diff 2 files changed, 97 insertions(+)

Step 1: Replaying Mode

Caution

Panic occurred during VCR tests

🔴 REPLAYING mode: The provider crashed with a panic. Please check the build log for details.

Please fix the issue to complete your PR.

View the build log

@vr-ibm VCR tests complete for e5675ff!

@vr-ibm
vr-ibm force-pushed the feat/secret-manager-secret-version-identity-clean branch from e5675ff to a7326b8 Compare July 29, 2026 18:50
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jul 29, 2026
@modular-magician

modular-magician commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a7326b8:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 101 insertions(+), 5 deletions(-)
google-beta provider View Diff 2 files changed, 101 insertions(+), 5 deletions(-)

Step 1: Replaying Mode

Caution

Panic occurred during VCR tests

🔴 REPLAYING mode: The provider crashed with a panic. Please check the build log for details.

Please fix the issue to complete your PR.

View the build log

@vr-ibm VCR tests complete for a7326b8!

@vr-ibm
vr-ibm force-pushed the feat/secret-manager-secret-version-identity-clean branch from a7326b8 to 1012449 Compare July 29, 2026 21:04
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jul 29, 2026
@modular-magician

modular-magician commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 1012449:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 3 files changed, 120 insertions(+), 8 deletions(-)
google-beta provider View Diff 3 files changed, 120 insertions(+), 8 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
47 36 5 6
Affected Service Packages
  • secretmanager

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccSecretManagerSecretVersion_secretVersionBasicExample
  • TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample
  • TestAccSecretManagerSecretVersion_secretVersionDeletionPolicyAbandonExample
  • TestAccSecretManagerSecretVersion_secretVersionDeletionPolicyDisableExample
  • TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataExample
  • TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccSecretManagerSecretVersion_secretVersionBasicExample
✅ Log TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample
✅ Log TestAccSecretManagerSecretVersion_secretVersionDeletionPolicyAbandonExample
✅ Log TestAccSecretManagerSecretVersion_secretVersionDeletionPolicyDisableExample
✅ Log TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataExample
✅ Log TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@vr-ibm VCR tests complete for 1012449!

@vr-ibm
vr-ibm marked this pull request as ready for review July 30, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants