fix stale IGM cache in node pool - #18454
Conversation
…izing or ignore_node_count_changes is active Fixes hashicorp/terraform-provider-google#27966 This PR fixes a bug where google_container_node_pool and google_container_cluster failed to invalidate their Instance Group Manager cache when a resize occurred or when ignore_node_count_changes was active. ```release-note:bug container: fixed a bug where `google_container_node_pool` and `google_container_cluster` failed to invalidate their Instance Group Manager cache when a resize occurred or when `ignore_node_count_changes` was active ```
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit f16989d: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. |
|
|
Fixes hashicorp/terraform-provider-google#27966
Splits #18397
This PR fixes a bug where stale Instance Group Manager target sizes were served from the client-side provider cache after GKE node count updates or when
ignore_node_count_changeswas active.To solve stale IGM target sizes, this PR:
invalidateItem(igmUrl)method toinstanceGroupManagerCacheto allow removing specific IGM entries.flattenNodePoolwhenignore_node_count_changesis active, as the cache isn't needed if we are ignoring the count.nodePoolUpdateafter a size update, ensuring subsequent reads fetch fresh GCE API data.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.