Skip to content

feat:(storage) added new resource google_storage_ftp_server - #18464

Draft
gurusai-voleti wants to merge 12 commits into
GoogleCloudPlatform:mainfrom
gurusai-voleti:ftp_server
Draft

feat:(storage) added new resource google_storage_ftp_server#18464
gurusai-voleti wants to merge 12 commits into
GoogleCloudPlatform:mainfrom
gurusai-voleti:ftp_server

Conversation

@gurusai-voleti

Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_storage_ftp_server`

@modular-magician

modular-magician commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit c502e5d:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 10 files changed, 614 insertions(+)
google-beta provider View Diff 14 files changed, 2042 insertions(+)
terraform-google-conversion View Diff 3 files changed, 336 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
6876 6154 706 16
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 16 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
  • TestAccContainerCluster_regionalWithNodePool
  • TestAccDataformConfig_update
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample
  • TestAccStorageFtpServer_storageFtpServerExternalExample
  • TestAccStorageFtpServer_storageFtpServerInternalExample
  • TestAccStorageFtpServer_updateExternal
  • TestAccStorageFtpServer_updateInternal
  • TestAccVertexAIFeatureOnlineStoreFeatureviewIamBindingGenerated
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_updated
  • TestAccVmwareengineNetworkPeering_update

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccVertexAIFeatureOnlineStoreFeatureviewIamBindingGenerated
✅ Log TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_updated
✅ Log TestAccVmwareengineNetworkPeering_update
✅ Log ❌ Error · Log TestAccDataformConfig_update
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
❌ Error · Log - TestAccContainerCluster_regionalWithNodePool
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample
❌ Error · Log - TestAccStorageFtpServer_storageFtpServerExternalExample
❌ Error · Log - TestAccStorageFtpServer_storageFtpServerInternalExample
❌ Error · Log - TestAccStorageFtpServer_updateExternal
❌ Error · Log - TestAccStorageFtpServer_updateInternal
❌ Error · Log - TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@gurusai-voleti, @kautikdk VCR tests complete for c502e5d!

@modular-magician

modular-magician commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 11590c0:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 11 files changed, 619 insertions(+)
google-beta provider View Diff 14 files changed, 2042 insertions(+)
terraform-google-conversion View Diff 3 files changed, 336 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
6876 6153 706 17
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccBigqueryReservationBiReservation_bigqueryReservationBiReservationFullExample
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
  • TestAccContainerCluster_regionalWithNodePool
  • TestAccDataformConfig_update
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample
  • TestAccStorageFtpServer_storageFtpServerExternalExample
  • TestAccStorageFtpServer_storageFtpServerInternalExample
  • TestAccStorageFtpServer_updateExternal
  • TestAccStorageFtpServer_updateInternal
  • TestAccVertexAIFeatureOnlineStoreFeatureviewIamBindingGenerated
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_updated

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccBigqueryReservationBiReservation_bigqueryReservationBiReservationFullExample
✅ Log TestAccDataformConfig_update
✅ Log TestAccProjectIamMemberRemove_memberInMultipleBindings
✅ Log TestAccVertexAIFeatureOnlineStoreFeatureviewIamBindingGenerated
✅ Log TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_updated
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
❌ Error · Log - TestAccContainerCluster_regionalWithNodePool
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample
❌ Error · Log - TestAccStorageFtpServer_storageFtpServerExternalExample
❌ Error · Log - TestAccStorageFtpServer_storageFtpServerInternalExample
❌ Error · Log - TestAccStorageFtpServer_updateExternal
❌ Error · Log - TestAccStorageFtpServer_updateInternal
❌ Error · Log - TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@gurusai-voleti, @kautikdk VCR tests complete for 11590c0!

@modular-magician

modular-magician commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 56f7111:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 12 files changed, 624 insertions(+)
google-beta provider View Diff 14 files changed, 2042 insertions(+)
terraform-google-conversion View Diff 3 files changed, 336 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
6876 6155 706 15
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
  • TestAccContainerCluster_regionalWithNodePool
  • TestAccDataformConfig_update
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample
  • TestAccStorageFtpServer_storageFtpServerExternalExample
  • TestAccStorageFtpServer_storageFtpServerInternalExample
  • TestAccStorageFtpServer_updateExternal
  • TestAccStorageFtpServer_updateInternal
  • TestAccVertexAIFeatureOnlineStoreFeatureviewIamBindingGenerated
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_updated

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccVertexAIFeatureOnlineStoreFeatureviewIamBindingGenerated
✅ Log TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_updated
✅ Log ❌ Error · Log TestAccDataformConfig_update
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
❌ Error · Log - TestAccContainerCluster_regionalWithNodePool
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample
❌ Error · Log - TestAccStorageFtpServer_storageFtpServerExternalExample
❌ Error · Log - TestAccStorageFtpServer_storageFtpServerInternalExample
❌ Error · Log - TestAccStorageFtpServer_updateExternal
❌ Error · Log - TestAccStorageFtpServer_updateInternal
❌ Error · Log - TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@gurusai-voleti, @kautikdk VCR tests complete for 56f7111!

@modular-magician

modular-magician commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e96ed5c:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 12 files changed, 627 insertions(+)
google-beta provider View Diff 14 files changed, 2045 insertions(+)
terraform-google-conversion View Diff 3 files changed, 336 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
6876 6154 706 16
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 16 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeRouterPeer_AddMd5AuthenticationKey
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
  • TestAccContainerCluster_regionalWithNodePool
  • TestAccDataformConfig_update
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample
  • TestAccStorageFtpServer_storageFtpServerExternalExample
  • TestAccStorageFtpServer_storageFtpServerInternalExample
  • TestAccStorageFtpServer_updateExternal
  • TestAccStorageFtpServer_updateInternal
  • TestAccVertexAIFeatureOnlineStoreFeatureviewIamBindingGenerated
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_updated

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccVertexAIFeatureOnlineStoreFeatureviewIamBindingGenerated
✅ Log TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_updated
✅ Log ❌ Error · Log TestAccComputeRouterPeer_AddMd5AuthenticationKey
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
❌ Error · Log - TestAccContainerCluster_regionalWithNodePool
❌ Error · Log - TestAccDataformConfig_update
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample
❌ Error · Log - TestAccStorageFtpServer_storageFtpServerExternalExample
❌ Error · Log - TestAccStorageFtpServer_storageFtpServerInternalExample
❌ Error · Log - TestAccStorageFtpServer_updateExternal
❌ Error · Log - TestAccStorageFtpServer_updateInternal
❌ Error · Log - TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@gurusai-voleti, @kautikdk VCR tests complete for e96ed5c!

@modular-magician

modular-magician commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit ca6666f:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 12 files changed, 627 insertions(+)
google-beta provider View Diff 14 files changed, 2045 insertions(+)
terraform-google-conversion View Diff 3 files changed, 336 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
6876 6155 706 15
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
  • TestAccContainerCluster_regionalWithNodePool
  • TestAccDataformConfig_update
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample
  • TestAccStorageFtpServer_storageFtpServerExternalExample
  • TestAccStorageFtpServer_storageFtpServerInternalExample
  • TestAccStorageFtpServer_updateExternal
  • TestAccStorageFtpServer_updateInternal
  • TestAccVertexAIFeatureOnlineStoreFeatureviewIamBindingGenerated
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_updated

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccDataformConfig_update
✅ Log TestAccVertexAIFeatureOnlineStoreFeatureviewIamBindingGenerated
✅ Log TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_updated
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
❌ Error · Log - TestAccContainerCluster_regionalWithNodePool
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample
❌ Error · Log - TestAccStorageFtpServer_storageFtpServerExternalExample
❌ Error · Log - TestAccStorageFtpServer_storageFtpServerInternalExample
❌ Error · Log - TestAccStorageFtpServer_updateExternal
❌ Error · Log - TestAccStorageFtpServer_updateInternal
❌ Error · Log - TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@gurusai-voleti, @kautikdk VCR tests complete for ca6666f!

@modular-magician

modular-magician commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 42ae24f:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 12 files changed, 409 insertions(+)
google-beta provider View Diff 14 files changed, 2042 insertions(+)
terraform-google-conversion View Diff 3 files changed, 336 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
6876 6154 706 16
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 16 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeRouterPeer_AddMd5AuthenticationKey
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
  • TestAccContainerCluster_regionalWithNodePool
  • TestAccDataformConfig_update
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample
  • TestAccStorageFtpServer_storageFtpServerExternalExample
  • TestAccStorageFtpServer_storageFtpServerInternalExample
  • TestAccStorageFtpServer_updateExternal
  • TestAccStorageFtpServer_updateInternal
  • TestAccVertexAIFeatureOnlineStoreFeatureviewIamBindingGenerated
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_updated

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeRouterPeer_AddMd5AuthenticationKey
✅ Log TestAccVertexAIFeatureOnlineStoreFeatureviewIamBindingGenerated
✅ Log TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_updated
✅ Log ❌ Error · Log TestAccDataformConfig_update
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
❌ Error · Log - TestAccContainerCluster_regionalWithNodePool
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample
❌ Error · Log - TestAccStorageFtpServer_storageFtpServerExternalExample
❌ Error · Log - TestAccStorageFtpServer_storageFtpServerInternalExample
❌ Error · Log - TestAccStorageFtpServer_updateExternal
❌ Error · Log - TestAccStorageFtpServer_updateInternal
❌ Error · Log - TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@gurusai-voleti, @kautikdk VCR tests complete for 42ae24f!

@modular-magician

modular-magician commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit dbf5509:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 12 files changed, 409 insertions(+)
google-beta provider View Diff 14 files changed, 2043 insertions(+)
terraform-google-conversion View Diff 3 files changed, 336 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
6879 6159 706 14
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 14 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
  • TestAccContainerNodePool_gcfsConfig
  • TestAccDataformConfig_update
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample
  • TestAccStorageFtpServer_storageFtpServerExternalExample
  • TestAccStorageFtpServer_storageFtpServerInternalExample
  • TestAccStorageFtpServer_updateExternal
  • TestAccStorageFtpServer_updateInternal
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccContainerNodePool_gcfsConfig
✅ Log TestAccProjectIamMemberRemove_memberInMultipleBindings
✅ Log ❌ Error · Log TestAccDataformConfig_update
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample
❌ Error · Log - TestAccStorageFtpServer_storageFtpServerExternalExample
❌ Error · Log - TestAccStorageFtpServer_storageFtpServerInternalExample
❌ Error · Log - TestAccStorageFtpServer_updateExternal
❌ Error · Log - TestAccStorageFtpServer_updateInternal
❌ Error · Log - TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@gurusai-voleti, @kautikdk VCR tests complete for dbf5509!

@modular-magician

modular-magician commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 10ace41:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 12 files changed, 409 insertions(+)
google-beta provider View Diff 14 files changed, 2044 insertions(+)
terraform-google-conversion View Diff 3 files changed, 336 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
6879 6158 706 15
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
  • TestAccDataformConfig_update
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample
  • TestAccStorageFtpServer_storageFtpServerExternalExample
  • TestAccStorageFtpServer_storageFtpServerInternalExample
  • TestAccStorageFtpServer_updateExternal
  • TestAccStorageFtpServer_updateInternal
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated
  • TestAccVertexAIReasoningEngine_vertexAiReasoningEngineUpdate

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
✅ Log TestAccDataformConfig_update
✅ Log TestAccVertexAIReasoningEngine_vertexAiReasoningEngineUpdate
✅ Log ❌ Error · Log TestAccProjectIamMemberRemove_memberInMultipleBindings
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample
❌ Error · Log - TestAccStorageFtpServer_storageFtpServerExternalExample
❌ Error · Log - TestAccStorageFtpServer_storageFtpServerInternalExample
❌ Error · Log - TestAccStorageFtpServer_updateExternal
❌ Error · Log - TestAccStorageFtpServer_updateInternal
❌ Error · Log - TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@gurusai-voleti, @kautikdk VCR tests complete for 10ace41!

Comment thread mmv1/products/storageftp/Server.yaml Outdated
@SirGitsalot

Copy link
Copy Markdown
Member

Committed my own code suggestion to see if I was able to successfully enable the API via gcloud (and to avoid another day of cross-continent code review round trips!)

@modular-magician

modular-magician commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 2de8702:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 12 files changed, 409 insertions(+)
google-beta provider View Diff 14 files changed, 2044 insertions(+)
terraform-google-conversion View Diff 3 files changed, 336 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
6879 6160 706 13
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 13 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
  • TestAccDataformConfig_update
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample
  • TestAccStorageFtpServer_storageFtpServerExternalExample
  • TestAccStorageFtpServer_storageFtpServerInternalExample
  • TestAccStorageFtpServer_updateExternal
  • TestAccStorageFtpServer_updateInternal
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccProjectIamMemberRemove_memberInMultipleBindings
✅ Log ❌ Error · Log TestAccDataformConfig_update
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample
❌ Error · Log - TestAccStorageFtpServer_storageFtpServerExternalExample
❌ Error · Log - TestAccStorageFtpServer_storageFtpServerInternalExample
❌ Error · Log - TestAccStorageFtpServer_updateExternal
❌ Error · Log - TestAccStorageFtpServer_updateInternal
❌ Error · Log - TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@gurusai-voleti, @kautikdk VCR tests complete for 2de8702!

@SirGitsalot SirGitsalot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regex take 2

Comment thread mmv1/products/storageftp/Server.yaml Outdated
@modular-magician

modular-magician commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e28b12d:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 12 files changed, 409 insertions(+)
google-beta provider View Diff 14 files changed, 2044 insertions(+)
terraform-google-conversion View Diff 3 files changed, 336 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
6881 6162 706 13
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 13 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
  • TestAccDataformConfig_update
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample
  • TestAccStorageFtpServer_storageFtpServerExternalExample
  • TestAccStorageFtpServer_storageFtpServerInternalExample
  • TestAccStorageFtpServer_updateExternal
  • TestAccStorageFtpServer_updateInternal
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccStorageFtpServer_storageFtpServerExternalExample
✅ Log TestAccStorageFtpServer_storageFtpServerInternalExample
✅ Log TestAccStorageFtpServer_updateExternal
✅ Log TestAccStorageFtpServer_updateInternal
✅ Log ❌ Error · Log TestAccDataformConfig_update
✅ Log ❌ Error · Log TestAccProjectIamMemberRemove_memberInMultipleBindings
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample
❌ Error · Log - TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@gurusai-voleti, @kautikdk VCR tests complete for e28b12d!

@SirGitsalot

Copy link
Copy Markdown
Member

The failing tests are unrelated. Not sure what's going on with teamcity-services-diff-check, the change to services_ga.kt looks fine to my eyes. I'll take a deeper look on Monday. Besides that, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants