Migrate data_source_google_compute_images.go data source to use direct HTTP rather than a client library - #18466
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 278e059: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @GitOleksandrBokov VCR tests complete for 278e059! |
Part of the ongoing migration of handwritten compute files from the Apiary client library to direct HTTP calls (
transport_tpg.SendRequest). Same pattern as #18444 and the merged data source migrations #17090 / #17117.NewClient(...).Images.List(project).Filter(filter).Do()withGET projects/{project}/global/imagesviatransport_tpg.SendRequest+transport_tpg.AddQueryParams.pageTokenpagination. The previous code issued a singleDo()call, which returns only the first page (server default 500 items) and silently truncated larger projects.filterquery parameter is sent unconditionally (even when empty) to keep the request shape identical to the typed client, so the recorded VCR cassette stays replay-compatible.pageTokenis only sent when non-empty for the same reason.archiveSizeBytes,diskSizeGbandidare parsed explicitly.idis uint64 upstream, so it is parsed withParseUintand cast toint64(same numeric behavior as the previous struct-based conversion).Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.