Migrate data_source_google_compute_interconnect_location.go data source to use direct HTTP rather than a client library - #18468
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit cc6866f: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @GitOleksandrBokov VCR tests complete for cc6866f! |
Part of the ongoing migration of handwritten compute files from the Apiary client library to direct HTTP calls (
transport_tpg.SendRequest). Same pattern as #18444 and the merged data source migrations #17090 / #17117.NewClient(...).InterconnectLocations.Get(project, name).Do()with aGETtoprojects/{project}/global/interconnectLocations/{name}. Note the REST URL uses camelCaseinterconnectLocations(same path the typed client used); the Terraform resource ID keeps its historical lowercaseinterconnectlocationsform, so state is unaffected.peeringdbFacilityId, which is a genuine string in the API), so they are passed tod.Setdirectly.d.SetId(location.Name)that was unconditionally overwritten by the finald.SetId(id)a few lines below.alt/prettyPrint; the URL path is unchanged).Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.