Skip to content

biglakeiceberg: suppress plan diff for write.parquet.compression-codec in iceberg table properties - #18472

Open
shuyama1 wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
shuyama1:fix-biglake-iceberg-properties-diff-suppress
Open

biglakeiceberg: suppress plan diff for write.parquet.compression-codec in iceberg table properties#18472
shuyama1 wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
shuyama1:fix-biglake-iceberg-properties-diff-suppress

Conversation

@shuyama1

@shuyama1 shuyama1 commented Jul 30, 2026

Copy link
Copy Markdown
Member

This PR fixes a bug where google_biglake_iceberg_table was experiencing plan-non-empty diffs during updates when the default property "write.parquet.compression-codec" (returned as "zstd" by the API) was not defined in the user's Terraform configuration.

By adding "write.parquet.compression-codec" to icebergTableIgnoredProperties, we suppress the diff when the property is not defined by the user.

Fixes hashicorp/terraform-provider-google#28299

biglakeiceberg: fixed perma-diff on `write.parquet.compression-codec` in `google_biglake_iceberg_table`

@modular-magician

modular-magician commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 0ca4464:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 1 insertion(+)
google-beta provider View Diff 1 file changed, 1 insertion(+)
terraform-google-conversion View Diff 1 file changed, 1 insertion(+)

Test report

Analytics

Total Tests Passed Skipped Affected
23 22 1 0
Affected Service Packages
  • biglakeiceberg

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@shuyama1, @wj-chen VCR tests complete for 0ca4464!

@modular-magician
modular-magician requested a review from wj-chen July 30, 2026 16:59
@shuyama1

shuyama1 commented Jul 30, 2026

Copy link
Copy Markdown
Member Author

run test on TC

Update: test passed

@shuyama1

Copy link
Copy Markdown
Member Author

@modular-magician reassign-reviewer

@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions
github-actions Bot requested a review from c2thorn July 30, 2026 22:50
@shuyama1 shuyama1 changed the title biglake: suppress plan diff for write.parquet.compression-codec in iceberg table properties biglakeiceberg: suppress plan diff for write.parquet.compression-codec in iceberg table properties Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccBiglakeIcebergIcebergTable_update

2 participants