workbench: diff-suppress server-injected version-description metadata - #18474
workbench: diff-suppress server-injected version-description metadata#18474jeffreylwang wants to merge 2 commits into
Conversation
The Workbench backend surfaces a system-owned instance metadata key `versionDescription` (a human-readable image description derived from the VmImage release configs, e.g. "Debian 11, Python 3.10"). Users never set it, so without a diff-suppress entry it causes a permadiff on google_workbench_instance (same class as new-proxy-agent-enabled, GoogleCloudPlatform#17310). Add it to WorkbenchInstanceProvidedMetadata (server-owned, always injected).
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
@bcreddy-gcp could you please take a look / review this? This adds |
|
Renamed the metadata key from |
The Workbench backend surfaces a system-owned instance metadata key
version-description(a human-readable image description derived from the VmImage release configs, e.g.Debian 11, Python 3.10). Users can never set this key, so thegoogle_workbench_instanceprovider must diff-suppress it; otherwise every Terraform-managed Workbench instance gets a permadiff (same class of issue asnew-proxy-agent-enabled, #17310).This adds
version-descriptiontoWorkbenchInstanceProvidedMetadata(purely server-owned, always injected, not EUC-specific).Context (Google-internal): b/539638368.