Use the new default value feature in api.yaml in terraform#201
Merged
Conversation
rosbo
commented
May 18, 2018
| check_optional_property :validation, Provider::Terraform::Validation | ||
| check_optional_property :set_hash_func, String | ||
|
|
||
| check_optional_property :update_statement, String |
Contributor
Author
There was a problem hiding this comment.
I also fixed a bug where these lines where in the wrong validate method
danawillow
approved these changes
May 18, 2018
| checkIntervalSec: !ruby/object:Provider::Terraform::PropertyOverride | ||
| default: !ruby/object:Provider::Terraform::Default | ||
| value: 5 | ||
| default_value: 5 |
Contributor
There was a problem hiding this comment.
This is also set in api.yaml. Any idea whether that was intentional?
Contributor
There was a problem hiding this comment.
Oh, you put that stuff in the PR description, cool. We'll talk about it another time :)
Collaborator
|
I am a robot that works on MagicModules PRs! Once this PR is approved, you can feel free to merge it without taking any further steps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Terraform had its own concept of default value. @rambleraptor added this feature to api.yaml yesterday #148. This PR updates Terraform to use the api.yaml default_value feature. As always, you can override it in a provider.
For now, I blindly updated our terraform.yaml file to simply use the override feature. We may, in a separate PR, move some of these values up to api.yaml
[all]
[terraform]
[puppet]
[puppet-dns]
[puppet-sql]
[puppet-compute]
[chef]