Skip to content

[Terraform] sql private ip support#938

Merged
modular-magician merged 13 commits into
masterfrom
tf-pr-145
Nov 21, 2018
Merged

[Terraform] sql private ip support#938
modular-magician merged 13 commits into
masterfrom
tf-pr-145

Conversation

@danawillow

Copy link
Copy Markdown
Contributor

Based off of hashicorp/terraform-provider-google-beta#145


[all]

[terraform]

Website changes for SQL private IP + new computed field

[terraform-beta]

Close this PR in favor of #145.

[ansible]

[inspec]

@googlebot

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@danawillow

Copy link
Copy Markdown
Contributor Author

This code is in a third party directory not subject to Google's CLA rules.

@modular-magician

Copy link
Copy Markdown
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#150
depends: hashicorp/terraform-provider-google#2509

@craigdbarber craigdbarber left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this.

@modular-magician modular-magician merged commit c4ca58e into master Nov 21, 2018
@danawillow danawillow deleted the tf-pr-145 branch December 7, 2018 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants