-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(storage): support delete source objects on compose #4360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
nidhiii-27
wants to merge
3
commits into
main
Choose a base branch
from
feat/storage-compose-delete-sources
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+123
−0
Draft
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,72 @@ | ||||||||||||||
| // Copyright 2024 Google LLC | ||||||||||||||
| // | ||||||||||||||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||||||||||||||
| // you may not use this file except in compliance with the License. | ||||||||||||||
| // You may obtain a copy of the License at | ||||||||||||||
| // | ||||||||||||||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||||||||||||||
| // | ||||||||||||||
| // Unless required by applicable law or agreed to in writing, software | ||||||||||||||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||||||||||||||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||||||||||||||
| // See the License for the specific language governing permissions and | ||||||||||||||
| // limitations under the License. | ||||||||||||||
|
|
||||||||||||||
| 'use strict'; | ||||||||||||||
|
|
||||||||||||||
| /** | ||||||||||||||
| * This application demonstrates how to compose/combine multiple files into a | ||||||||||||||
| * single destination file with the Google Cloud Storage API. | ||||||||||||||
| * | ||||||||||||||
| * For more information, see the README.md under /storage and the documentation | ||||||||||||||
| * at https://cloud.google.com/storage/docs. | ||||||||||||||
| */ | ||||||||||||||
|
|
||||||||||||||
| function main( | ||||||||||||||
| bucketName = 'my-bucket', | ||||||||||||||
| firstFileName = 'first.txt', | ||||||||||||||
| secondFileName = 'second.txt', | ||||||||||||||
| destinationFileName = 'destination.txt', | ||||||||||||||
| deleteSourceObjects = false | ||||||||||||||
| ) { | ||||||||||||||
| // [START storage_compose_file] | ||||||||||||||
| /** | ||||||||||||||
| * TODO(developer): Uncomment the following lines before running the sample. | ||||||||||||||
| */ | ||||||||||||||
| // const bucketName = 'your-unique-bucket-name'; | ||||||||||||||
| // const firstFileName = 'first.txt'; | ||||||||||||||
| // const secondFileName = 'second.txt'; | ||||||||||||||
| // const destinationFileName = 'destination.txt'; | ||||||||||||||
| // const deleteSourceObjects = false; | ||||||||||||||
|
|
||||||||||||||
| // Imports the Google Cloud client library | ||||||||||||||
| const {Storage} = require('@google-cloud/storage'); | ||||||||||||||
|
|
||||||||||||||
| // Creates a client | ||||||||||||||
| const storage = new Storage(); | ||||||||||||||
|
|
||||||||||||||
| async function composeFile() { | ||||||||||||||
| const bucket = storage.bucket(bucketName); | ||||||||||||||
| const sources = [firstFileName, secondFileName]; | ||||||||||||||
|
|
||||||||||||||
| await bucket.combine(sources, destinationFileName); | ||||||||||||||
|
|
||||||||||||||
| console.log( | ||||||||||||||
| `New composite file ${destinationFileName} was created by combining ${sources.join(', ')}` | ||||||||||||||
| ); | ||||||||||||||
|
Comment on lines
+54
to
+56
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instead of hardcoding the file names in the log message, use
Suggested change
|
||||||||||||||
|
|
||||||||||||||
| if (String(deleteSourceObjects) === 'true') { | ||||||||||||||
| await Promise.all( | ||||||||||||||
| sources.map(async source => { | ||||||||||||||
| await bucket.file(source).delete(); | ||||||||||||||
| }) | ||||||||||||||
| ); | ||||||||||||||
| console.log(`Deleted source objects: ${sources.join(', ')}`); | ||||||||||||||
| } | ||||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
| composeFile().catch(console.error); | ||||||||||||||
| // [END storage_compose_file] | ||||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
| main(...process.argv.slice(2)); | ||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The JSDoc comment describes Access Control Lists (ACLs), which is incorrect and appears to be a copy-paste error. It should be updated to accurately describe composing/combining files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Co-authored by AI Agent