test(integration): harden network block wait in health check tests#2369
Open
rafaelwestphal wants to merge 1 commit into
Open
test(integration): harden network block wait in health check tests#2369rafaelwestphal wants to merge 1 commit into
rafaelwestphal wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TestNetworkHealthCheck occasionally flakes (reporting false passes on blocked endpoints) because the deny-egress firewall rule propagation is eventually consistent.
The existing waitForNetworkBlock helper only polled a single telemetry endpoint (telemetry.googleapis.com) to determine if the block was active. However, because GCP firewall rules propagate to different IP ranges at slightly different times, other endpoints (like package repositories or download servers) could still be reachable when the health check started, causing the test to fail its assertions.
Solution
Hardened waitForNetworkBlock to poll all three critical endpoints that are verified by the health checks:
telemetry.googleapis.com (Telemetry API)
dl.google.com (Download/DL API)
packages.cloud.google.com (Packages API)
The helper now waits until all three endpoints are completely unreachable (all connections fail) before allowing the test to proceed. If any endpoint is still reachable, it continues polling, ensuring the firewall block has fully propagated across all relevant ranges.
Related issue
How has this been tested?
Checklist: