Skip to content

Conversation

@dhavalbhensdadiya-crest

As part of this feature, we have added global and regional samples for below features:

  1. Create Secret With Expiration
  2. Update Secret With Expiration
  3. Remove expiration from Secret

Please merge this PR once approved

@product-auto-label product-auto-label bot added the api: secretmanager Issues related to the Secret Manager API. label Jan 28, 2026
@snippet-bot
Copy link

snippet-bot bot commented Jan 28, 2026

Here is the summary of changes.

You are about to add 20 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 28, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello @dhavalbhensdadiya-crest, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Google Cloud Secret Manager PHP client samples by introducing a suite of new functionalities. It provides developers with clear examples for managing secret lifecycles through expiration settings, ensuring secure and efficient secret rotation. Furthermore, it demonstrates best practices for optimistic concurrency control using ETags across various secret and secret version operations, preventing conflicts in concurrent environments. The addition of filtered listing examples also improves the ability to query and manage secrets programmatically.

Highlights

  • Secret Expiration Management: New samples have been added for creating, updating, and removing Time-To-Live (TTL) based expirations for both global and regional Google Cloud Secret Manager secrets.
  • Optimistic Concurrency with ETags: A comprehensive set of samples demonstrating the use of ETags for optimistic concurrency control has been introduced. These cover operations such as deleting secrets, and destroying, disabling, enabling, or updating secret versions, for both global and regional secrets.
  • Filtered Listing Capabilities: New samples are now available to list secrets and secret versions using filters, enhancing the discoverability and management of secrets within a project or location.
  • Expanded Test Coverage: Corresponding unit tests have been added and updated in regionalsecretmanagerTest.php and secretmanagerTest.php to validate the functionality of all new samples, ensuring their reliability and correctness.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a valuable set of new samples for Secret Manager, covering secret expiration, etag-based optimistic concurrency, and filtering for both global and regional secrets. The code is well-structured and the new test cases provide good coverage. I've identified a few minor areas for improvement, mainly concerning output formatting in the CLI samples and adherence to PHP coding standards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant