Skip to content

Conversation

@dhavalbhensdadiya-crest

As part of this feature, we have added global and regional samples for below features:

  1. Create secret with CMEK
  2. Create secret with Topic

Please merge this PR once approved

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 28, 2026
@snippet-bot
Copy link

snippet-bot bot commented Jan 28, 2026

Here is the summary of changes.

You are about to add 24 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@gemini-code-assist
Copy link

Summary of Changes

Hello @dhavalbhensdadiya-crest, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces new PHP samples for Google Cloud Secret Manager. These samples demonstrate how to create secrets with CMEK, associate them with Pub/Sub topics, manage regional secrets, utilize ETags for concurrency control, handle secret expiration, and filter secrets and their versions. The changes enhance the Secret Manager's functionality by providing more comprehensive examples for various use cases.

Highlights

  • New Samples: Added samples for creating secrets with CMEK and Pub/Sub topics in PHP.
  • Regional Support: Introduced regional samples for secret management, including creating, updating, deleting, and managing secret versions.
  • ETag Usage: Demonstrated the use of ETags for optimistic concurrency control in secret and secret version management.
  • Expiration Management: Added samples for managing secret expiration using TTL.
  • Filtering: Introduced samples for listing secrets and secret versions with filters.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds several new PHP samples for Google Secret Manager, demonstrating features like creating secrets with CMEK, Pub/Sub topics, and expiration settings. The changes also include corresponding test cases. The implementation is generally good, but I've identified several areas for improvement related to code consistency, documentation clarity, and minor formatting issues. Addressing these points will enhance the quality and maintainability of the new samples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant