-
Notifications
You must be signed in to change notification settings - Fork 1k
Added samples for creating secret with CMEK and Pub/Sub Topic #2185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Added samples for creating secret with CMEK and Pub/Sub Topic #2185
Conversation
…with expiration TTL
|
Here is the summary of changes. You are about to add 24 region tags.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @dhavalbhensdadiya-crest, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces new PHP samples for Google Cloud Secret Manager. These samples demonstrate how to create secrets with CMEK, associate them with Pub/Sub topics, manage regional secrets, utilize ETags for concurrency control, handle secret expiration, and filter secrets and their versions. The changes enhance the Secret Manager's functionality by providing more comprehensive examples for various use cases. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds several new PHP samples for Google Secret Manager, demonstrating features like creating secrets with CMEK, Pub/Sub topics, and expiration settings. The changes also include corresponding test cases. The implementation is generally good, but I've identified several areas for improvement related to code consistency, documentation clarity, and minor formatting issues. Addressing these points will enhance the quality and maintainability of the new samples.
737ee06 to
776f3b1
Compare
As part of this feature, we have added global and regional samples for below features:
Please merge this PR once approved