chore: move from bingo to go tool#1861
Conversation
40b0f57 to
049d37c
Compare
|
Happy to remove bingo fully too. Looks like some tests to fix still? |
|
I think it would be nice to not depend on Bingo, if However, the latest version of Helm seems to have newer Kubernetes dependencies that forced a bunch of stuff to bump up, and broke things. I'll probably park this for now, since it's not a top priority. |
f3ee890 to
ec41a00
Compare
bwplotka
left a comment
There was a problem hiding this comment.
This change moves the Helm dependency to a go tool instead of bingo.
As a result, bingo will no longer be required on local dev environment to run non-docker manifest generation.
Can we remove the use of bingo in hack/Dockerfile to test if we accomplished that with helm removal?
I also wonder why we needed to do this get if we use ${HELM} that should not need bingo get but instead use variables.env which will auto-build if needed.
Still helm build was taking long, so maybe it's faster with go tool plus we could remove bingo all together, so good for consistency.
Second question is around go module per tool. I'd prefer a single tool go module so we can minimize vendor and complexity (might be relevant for vendoring step in Louhi). With multiple go modules per tool we kind of build bingo again from scratch, manually 🙈
So to suggestions:
- Let's try one tool go mod
- Let's actually remove
bingo getto see if things works (perhaps it worked without helm move 🤔 )
7cd2fd2 to
8885c2a
Compare
8885c2a to
6824889
Compare
This replaces all tools currently installed with Bingo with go tool instead. Signed-off-by: Adam Bernot <bernot@google.com>
6824889 to
af2cf79
Compare
bwplotka
left a comment
There was a problem hiding this comment.
Let's go, thank you for helping!
| go.uber.org/zap v1.27.0 | ||
| golang.org/x/mod v0.29.0 | ||
| golang.org/x/oauth2 v0.30.0 | ||
| golang.org/x/mod v0.30.0 |
There was a problem hiding this comment.
Unrelated change, but low risk, so fine 👍🏽
This change moves tool dependencies to
go toolinstead ofbingo.Bingo will no longer be required.