Skip to content

chore: move from bingo to go tool#1861

Merged
bernot-dev merged 3 commits intomainfrom
rm-bingo-helm
Feb 9, 2026
Merged

chore: move from bingo to go tool#1861
bernot-dev merged 3 commits intomainfrom
rm-bingo-helm

Conversation

@bernot-dev
Copy link
Copy Markdown
Collaborator

@bernot-dev bernot-dev commented Feb 3, 2026

This change moves tool dependencies to go tool instead of bingo.

Bingo will no longer be required.

@bernot-dev bernot-dev requested a review from bwplotka February 3, 2026 16:14
@bernot-dev bernot-dev self-assigned this Feb 3, 2026
@bwplotka
Copy link
Copy Markdown
Collaborator

bwplotka commented Feb 4, 2026

Happy to remove bingo fully too.

Looks like some tests to fix still?

@bernot-dev
Copy link
Copy Markdown
Collaborator Author

I think it would be nice to not depend on Bingo, if go tool can meet our needs.

However, the latest version of Helm seems to have newer Kubernetes dependencies that forced a bunch of stuff to bump up, and broke things. I'll probably park this for now, since it's not a top priority.

@bernot-dev bernot-dev force-pushed the rm-bingo-helm branch 5 times, most recently from f3ee890 to ec41a00 Compare February 6, 2026 15:24
@bernot-dev bernot-dev enabled auto-merge (rebase) February 6, 2026 15:39
Copy link
Copy Markdown
Collaborator

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change moves the Helm dependency to a go tool instead of bingo.
As a result, bingo will no longer be required on local dev environment to run non-docker manifest generation.

Can we remove the use of bingo in hack/Dockerfile to test if we accomplished that with helm removal?

Image

I also wonder why we needed to do this get if we use ${HELM} that should not need bingo get but instead use variables.env which will auto-build if needed.

Image

Still helm build was taking long, so maybe it's faster with go tool plus we could remove bingo all together, so good for consistency.

Second question is around go module per tool. I'd prefer a single tool go module so we can minimize vendor and complexity (might be relevant for vendoring step in Louhi). With multiple go modules per tool we kind of build bingo again from scratch, manually 🙈

So to suggestions:

  • Let's try one tool go mod
  • Let's actually remove bingo get to see if things works (perhaps it worked without helm move 🤔 )

Comment thread hack/presubmit.sh Outdated
Comment thread hack/presubmit.sh Outdated
Comment thread tools/helm/go.mod Outdated
Comment thread hack/presubmit.sh Outdated
@bernot-dev bernot-dev force-pushed the rm-bingo-helm branch 2 times, most recently from 7cd2fd2 to 8885c2a Compare February 6, 2026 17:51
@bernot-dev bernot-dev changed the title chore: move helm from bingo to go tool chore: move from bingo to go tool Feb 6, 2026
This replaces all tools currently installed with Bingo with go tool
instead.

Signed-off-by: Adam Bernot <bernot@google.com>
Copy link
Copy Markdown
Collaborator

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go, thank you for helping!

Comment thread go.mod
go.uber.org/zap v1.27.0
golang.org/x/mod v0.29.0
golang.org/x/oauth2 v0.30.0
golang.org/x/mod v0.30.0
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change, but low risk, so fine 👍🏽

@bernot-dev bernot-dev merged commit c69c852 into main Feb 9, 2026
39 checks passed
@bernot-dev bernot-dev deleted the rm-bingo-helm branch February 18, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants