chore(deps): update openjdk docker tag to v11 - autoclosed#14206
Closed
renovate-bot wants to merge 1 commit into
Closed
chore(deps): update openjdk docker tag to v11 - autoclosed#14206renovate-bot wants to merge 1 commit into
renovate-bot wants to merge 1 commit into
Conversation
trusted-contributions-gcf
Bot
added
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
product-auto-label
Bot
added
the
samples
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the JRE base image in the Dockerfile from OpenJDK 8 to OpenJDK 11.0.16. A critical issue was identified where the file paths, environment variables, and system alternatives still reference the old OpenJDK 8 directory, which does not exist in the new image and will lead to build failures.
Comment on lines
+24
to
26
| COPY --from=openjdk:11.0.16-jre-slim /usr/local/openjdk-8 /usr/local/openjdk-8 | ||
| ENV JAVA_HOME /usr/local/openjdk-8 | ||
| RUN update-alternatives --install /usr/bin/java java /usr/local/openjdk-8/bin/java 10 |
Contributor
There was a problem hiding this comment.
The source path /usr/local/openjdk-8 does not exist in the openjdk:11.0.16-jre-slim image; the correct path for this version is /usr/local/openjdk-11. Additionally, the destination path, JAVA_HOME environment variable, and update-alternatives configuration should be updated to reflect the version change to ensure consistency and avoid build failures.
COPY --from=openjdk:11.0.16-jre-slim /usr/local/openjdk-11 /usr/local/openjdk-11
ENV JAVA_HOME /usr/local/openjdk-11
RUN update-alternatives --install /usr/bin/java java /usr/local/openjdk-11/bin/java 10
renovate-bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
8-jre-slim→11.0.16-jre-slimWarning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.