Defer shortcut setup to MainActivity#215
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/Goooler/Tabby/sessions/62ab7036-bf7b-41ef-a64f-e748885cdf40 Co-authored-by: Goooler <10363352+Goooler@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Goooler
May 9, 2026 05:17
View session
There was a problem hiding this comment.
Pull request overview
This PR moves dynamic shortcut creation out of Application.onCreate() (which runs in all processes) and into MainActivity, and stops explicitly purging shortcuts when the launcher alias is disabled.
Changes:
- Removed shortcut setup (and
UiStoredependency) fromMainApplication. - Added shortcut setup to
MainActivity.onCreate(), skipping creation whenhideAppIconis enabled. - Removed
removeAllDynamicShortcuts()call fromAppSettingsActivitywhen hiding the app icon.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| app/src/main/java/com/github/kr328/clash/MainApplication.kt | Removes dynamic shortcut setup from app startup to avoid running it in non-main processes. |
| app/src/main/java/com/github/kr328/clash/MainActivity.kt | Creates dynamic shortcuts during activity creation instead of application startup. |
| app/src/main/java/com/github/kr328/clash/AppSettingsActivity.kt | Stops purging shortcuts when toggling the launcher alias state. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Goooler
added a commit
that referenced
this pull request
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shortcuts were being set up (and torn down) in
Application.onCreate(), which runs in every process and requires eagerly readingUiStore. They were also being explicitly removed when the user hid the app icon.Changes
MainApplication: RemovesetupShortcuts()and itsuiStoredependency entirelyMainActivity: CallsetupShortcuts()inonCreate(); bail early ifhideAppIconis set — no removal neededAppSettingsActivity: DropShortcutManagerCompat.removeAllDynamicShortcuts()fromonHideIconChange()— disabling the launcher alias is sufficient; existing shortcuts don't need to be purgedPorts #214.