Support updating editable items#241
Merged
Merged
Conversation
Goooler
force-pushed
the
support-re-edit-list-items
branch
from
03018c9 to
f0107d5
Compare
Goooler
force-pushed
the
support-re-edit-list-items
branch
from
f0107d5 to
481704b
Compare
Goooler
force-pushed
the
support-re-edit-list-items
branch
from
8b65db7 to
c28c10c
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds “edit existing item” support to the settings screens that manage editable string sets and key/value maps, allowing users to tap an existing row to open the same input dialog pre-filled for updating.
Changes:
- Add item tap handling to open the input dialog in “edit” mode (tracking the currently edited value/key).
- Pre-fill dialog text fields when editing and reset edit state on dismiss/confirm.
- Update confirm logic to replace existing entries safely (including handling key changes in the map editor).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ui/settings/src/main/kotlin/com/github/kr328/clash/settings/ui/EditableTextSetScreen.kt | Adds tap-to-edit for set entries and supports pre-filled single-text dialog with update/replace logic. |
| ui/settings/src/main/kotlin/com/github/kr328/clash/settings/ui/EditableTextMapScreen.kt | Adds tap-to-edit for map entries, pre-fills key/value dialog, and updates replace/merge logic when editing keys. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.