UI loading#41
Open
Vinaykumar-Manda wants to merge 11 commits into
Open
Conversation
…he XML files (#3) (#4) * Added models for ipconfig and pinconfig * Added InputConfigRepo and updated models * Minor changes * Added hascode & equals methods for Pinconfig * Addressed review comments * Merge branch 'dev' into sbokku-test Co-authored-by: Sujana2422 <86820188+Sujana2422@users.noreply.github.com>
* Changes done for ip config view. 1. Updated the slave update to not clearing existing slaves. 2. Updated the scl and sda pin combo boxes to contain disabled pins. 3. Removed disabled pins row. * IP Pin changes done when Ip configuration updated * Addressed review comments * Pin config UI changes (#31) * Added pinType model and parser for pin value types * Added pin config UI changes * Updated save data in Pin config as per new changes * Fixed prompt message not updated when we reset the combo box data * Prefilled the data from board configuration files --------- Co-authored-by: Sindhu Boinapalli <sindhu.boinapalli@invecas.com> Co-authored-by: vinay kumar chanda <vinaykumar.chanda@invecas.com> * Added changes to Bypass mode * Integrated QSPI changes in the app (#32) * Removed unwanted files --------- Co-authored-by: SKaparthi <kap.srichandra@gmail.com> Co-authored-by: chiranjeevi.pasupuleti <chiranjeevi.pasupuleti@invecas.com> Co-authored-by: chiruaj <30770028+chiruaj@users.noreply.github.com> Co-authored-by: SindhuBoinapalli <43169085+SindhuKonda@users.noreply.github.com> Co-authored-by: Sindhu Boinapalli <sindhu.boinapalli@invecas.com> Co-authored-by: vinay kumar chanda <vinaykumar.chanda@invecas.com> Co-authored-by: Jagadeesh Jami <jaggu1232000@gmail.com> Co-authored-by: Sujana2422 <86820188+Sujana2422@users.noreply.github.com> Co-authored-by: jaggusri12 <64919265+jaggusri12@users.noreply.github.com>
added the listerners for the paths in the loadDataController
Vinaykumar-Manda
assigned
chiruaj,
SindhuKonda,
chvinay419,
jaggusri12,
Srichandra03,
Gopal-moyya and
Sujana2422
Gopal-moyya
reviewed
May 9, 2024
| <scope>system</scope> | ||
| <systemPath>${basedir}/libs/CodeGeneration_jar/CodeGeneration.jar</systemPath> | ||
| </dependency> | ||
| <!-- <dependency>--> |
Gopal-moyya
reviewed
May 9, 2024
| @@ -0,0 +1,92 @@ | |||
| <root> | |||
Gopal-moyya
reviewed
May 9, 2024
| @@ -0,0 +1,74 @@ | |||
| <?xml version="1.0" ?> | |||
Gopal-moyya
reviewed
May 9, 2024
| } | ||
|
|
||
| public void onSubmit() { | ||
| System.out.println("onSubmit clicked"); |
Owner
There was a problem hiding this comment.
Add logger messages and remove system.out
Gopal-moyya
reviewed
May 9, 2024
| Parent fxml = null; | ||
| FXMLLoader loader = new FXMLLoader(getClass().getResource("load-data-view.fxml")); | ||
| LoadDataController loadDataController = new LoadDataController(this, xmlFolderPath); | ||
| LoadDataController loadDataController = new LoadDataController(this, xmlFolderPath, repositoryFolderPath, toolChainFolderPath, outputLocationFolderPath); |
Owner
There was a problem hiding this comment.
Instead of passing these many arguments, better to use an object that should store all these paths.
Gopal-moyya
reviewed
May 9, 2024
| folderPaths.put("output",outputPath); | ||
| } | ||
|
|
||
| Alert successAlert = new Alert(Alert.AlertType.INFORMATION); |
Owner
There was a problem hiding this comment.
Alert variable name should alert, it shouldn't be successAlert as you are using it for both success and failure
Gopal-moyya
reviewed
May 9, 2024
Gopal-moyya
reviewed
May 9, 2024
Gopal-moyya
left a comment
Gopal-moyya
left a comment
Owner
There was a problem hiding this comment.
Address the review comments
Gopal-moyya
reviewed
May 14, 2024
| if (allFields){ | ||
| submitBtn.setDisable(false); | ||
| } | ||
| boolean allFields = StringUtils.isNotEmpty(configPathsModel.getXmlPath()) && |
Owner
There was a problem hiding this comment.
Write a method inside configpathsmodel class to validate all these fields like below,
public boolean isValid(){
//check for path availability and return the response from here.
Gopal-moyya
reviewed
May 14, 2024
| default: | ||
| break; | ||
| } | ||
| boolean allFields = StringUtils.isNotEmpty(configPathsModel.getXmlPath()) && |
Owner
There was a problem hiding this comment.
implement the same method here also
Gopal-moyya
reviewed
May 14, 2024
| { | ||
| Node sourceNode = (Node) event.getSource(); | ||
| switch (sourceNode.getId().toString()){ | ||
| case "xmlPathField": |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the loader
Added the key typed listeners to the paths in the load view fxml