Fixing the input and output validation for the Junction class - #1
Open
Dilosch03 wants to merge 1 commit into
Open
Fixing the input and output validation for the Junction class#1Dilosch03 wants to merge 1 commit into
Dilosch03 wants to merge 1 commit into
Conversation
-Fix logic operator: or → and so that N:1 and 1:N junctions are correctly allowed (previously only 1:1 passed) -Add missing raise keyword on CircuitException, before the exception was created but never thrown. -Add guard against zero-value inputs/outputs (n_inputs < 1 or n_outputs < 1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Added missing raise keyword — CircuitException(...) by itself just creates the error object and discards it. Without raise, Python never actually stops execution, so invalid junctions were silently accepted.
-Fixed logic operator, ‘or’ to ‘and’ — The original check n_inputs != 1 or n_outputs != 1 rejected every junction except 1:1, making splitters (1:3) and mergers (3:1) impossible. Changed to and so it only rejects when neither side is 1.
-Added zero-side guard — New check rejects junctions with 0 inputs or 0 outputs, which would crash in step().