fix(#3637): adjust the checkbox on table header row to prevent height…#3719
Merged
chrisolsen merged 1 commit intodevfrom Apr 7, 2026
Merged
fix(#3637): adjust the checkbox on table header row to prevent height…#3719chrisolsen merged 1 commit intodevfrom
chrisolsen merged 1 commit intodevfrom
Conversation
Spark450
added
the
P3
mxsoco
force-pushed
the
mxsoco/3637-header-row-checkbox
branch
from
ac6d4af to
ebe9991
Compare
bdfranck
reviewed
Mar 31, 2026
Collaborator
bdfranck
left a comment
bdfranck
left a comment
There was a problem hiding this comment.
@mxsoco Good catch on the th.goa-table-cell--checkbox selector! That solves the padding issue.
Since it's contained in a table cell, we can use vertical-align: middle like they did in https://github.com/GovAlta/goa-workspace-playground.
mxsoco
force-pushed
the
mxsoco/3637-header-row-checkbox
branch
from
589bbbd to
ef2d6e2
Compare
bdfranck
approved these changes
Apr 2, 2026
Collaborator
bdfranck
left a comment
bdfranck
left a comment
There was a problem hiding this comment.
I tested the latest changes...
- ✅ The checkbox is vertically aligned in the table header
Looks good to me! 👍
mxsoco
force-pushed
the
mxsoco/3637-header-row-checkbox
branch
from
ef2d6e2 to
ec7298e
Compare
Collaborator
|
@mxsoco rebase this and I will merge it. |
mxsoco
force-pushed
the
mxsoco/3637-header-row-checkbox
branch
from
ec7298e to
8caabbd
Compare
Collaborator
Author
Done! |
chrisolsen
approved these changes
Apr 7, 2026
Collaborator
|
🎉 This PR is included in version 2.0.0-dev.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before (the change)
Height increases with the checkbox added to the header row.
After (the change)
Along with applying an existing token to the top padding of the checkbox, I added new token to the bottom padding of the checkbox on header so it lines up with the rest of the header row.
Linked Design Token PR: #3637