Skip to content

fix(#5181): make variant optional in Angular goab-file-upload-input#3757

Draft
Copilot wants to merge 2 commits intodevfrom
copilot/update-goab-file-upload-input
Draft

fix(#5181): make variant optional in Angular goab-file-upload-input#3757
Copilot wants to merge 2 commits intodevfrom
copilot/update-goab-file-upload-input

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 2, 2026

variant was marked required: true in the Angular wrapper despite having a default value of "dragdrop" in the Svelte web component and being optional in React.

Before (the change)

@Input({ required: true }) variant!: GoabFileUploadInputVariant;

Angular consumers were forced to always specify variant, causing a compile error if omitted.

After (the change)

@Input() variant: GoabFileUploadInputVariant = "dragdrop";

variant is now optional and defaults to "dragdrop", consistent with the web component and React wrapper.

Make sure that you've checked the boxes below before you submit the PR

  • I have read and followed the setup steps
  • I have created necessary unit tests
  • I have tested the functionality in both React and Angular.

Steps needed to test

Use goab-file-upload-input in Angular without specifying variant and confirm it renders as dragdrop without a compile error:

<goab-file-upload-input (onSelectFile)="handleFileChange($event)"></goab-file-upload-input>

Copilot AI linked an issue Apr 2, 2026 that may be closed by this pull request
The variant property was marked as required in the Angular wrapper but
has a default value of "dragdrop" in the Svelte web component and is
optional in the React wrapper.

Closes #5181

Agent-Logs-Url: https://github.com/GovAlta/ui-components/sessions/1155e565-5d26-48f5-9276-ea56b9f674ca

Co-authored-by: bdfranck <1479091+bdfranck@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix required variant property for Angular file upload fix(#5181): make variant optional in Angular goab-file-upload-input Apr 2, 2026
Copilot AI requested a review from bdfranck April 2, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File Upload variant is required for Angular

2 participants