fix(#5181): make variant optional in Angular goab-file-upload-input#3757
Draft
fix(#5181): make variant optional in Angular goab-file-upload-input#3757
variant optional in Angular goab-file-upload-input#3757Conversation
The variant property was marked as required in the Angular wrapper but has a default value of "dragdrop" in the Svelte web component and is optional in the React wrapper. Closes #5181 Agent-Logs-Url: https://github.com/GovAlta/ui-components/sessions/1155e565-5d26-48f5-9276-ea56b9f674ca Co-authored-by: bdfranck <1479091+bdfranck@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix required variant property for Angular file upload
fix(#5181): make Apr 2, 2026
variant optional in Angular goab-file-upload-input
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
variantwas markedrequired: truein the Angular wrapper despite having a default value of"dragdrop"in the Svelte web component and being optional in React.Before (the change)
Angular consumers were forced to always specify
variant, causing a compile error if omitted.After (the change)
variantis now optional and defaults to"dragdrop", consistent with the web component and React wrapper.Make sure that you've checked the boxes below before you submit the PR
Steps needed to test
Use
goab-file-upload-inputin Angular without specifyingvariantand confirm it renders asdragdropwithout a compile error: