Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an issue in Chrome where clicking the close icon on the v1 filter chip can fail due to focus-triggered re-rendering of the goa-icon shadow DOM mid-gesture.
Changes:
- Disable pointer event handling on the v1 close icon so pointer events consistently target the chip container click handler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before (the change)
After (the change)
The reason
The problem is a race between Chrome's focus event and the
goa-iconshadow DOM re-render:mousedownongoa-icon→ browser focuses the parentdivfocusfires →_focused = true→ Svelte re-rendersgoa-iconreceives newtheme="filled"prop → shadow DOM re-renders under the cursormouseup/clickfire — but Chrome sees the hit-target changed, soclickis droppedFirefox is more permissive and fires
clickeven when the shadow DOM target shifts mid-gesture, which is why it works there on the first click.Adding
pointer-events: noneto.delete-iconmakes thegoa-iconelement transparent to all mouse events, so every click falls straight through to the outerdiv.chipthat holds theon:click={onDelete}handler. The icon in the v1 chip is purely decorative anyway — the whole chip is meant to be the button.