feat(i18n): extract MaintainersPage tabs and errors to message catalog#422
Open
Sandii00 wants to merge 3 commits into
Open
feat(i18n): extract MaintainersPage tabs and errors to message catalog#422Sandii00 wants to merge 3 commits into
Sandii00 wants to merge 3 commits into
Conversation
…place hardcoded strings in MaintainersPage with catalog refs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #263
Summary
Extracts all hardcoded strings from
src/features/maintainers/pages/MaintainersPage.tsxinto theeni18n catalog under a newmaintainers.*namespace, then replaces every occurrence with a typed catalog reference viauseTranslation().Changed files
src/shared/i18n/messages.ts— Addedmaintainers.*namespace (6 keys + TSDoc)src/features/maintainers/pages/MaintainersPage.tsx— ImportuseTranslation; replace hardcoded stringssrc/features/maintainers/pages/MaintainersPage.test.tsx— New test file (8 describe blocks)Catalog additions
maintainers.tabs.dashboard,maintainers.tabs.issues,maintainers.tabs.pullRequestsmaintainers.errors.unauthenticated,maintainers.errors.networkError,maintainers.errors.loadFailureBehavior
No behavior change — tab routing order,
TabTypevalues, and error semantics are identical.Test results
Coverage is well above the 95% target.
Security notes
None — static keys only, no dynamic key construction.