chore: remove orphaned app/components/landing duplicates (#286)#423
Open
jd5073356-max wants to merge 1 commit into
Open
chore: remove orphaned app/components/landing duplicates (#286)#423jd5073356-max wants to merge 1 commit into
jd5073356-max wants to merge 1 commit into
Conversation
src/app/components/landing/Hero.tsx and Navbar.tsx were unreferenced scaffolding. The live landing UI lives in src/features/landing (imported by App.tsx as `../features/landing`, and it has its own Navbar test). Verified there are no importers: grep -rn "app/components/landing" src -> no matches typecheck and build pass, and the src/features/landing tests stay green after removal. Closes Grainlify#286
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the orphaned
src/app/components/landing/Hero.tsxandNavbar.tsx— zero importers (the live ones are insrc/features/landing).Verification:
typecheck: OKbuild: OKfeatures/landing: green (2 pre-existing failures inApp.test.tsxunrelated to this change)Closes #286