feat(ux): add processing/loading state to BillingProfileCard (#273)#424
Open
jd5073356-max wants to merge 1 commit into
Open
feat(ux): add processing/loading state to BillingProfileCard (#273)#424jd5073356-max wants to merge 1 commit into
jd5073356-max wants to merge 1 commit into
Conversation
…fy#273) BillingProfileCard had no in-card feedback while an action was processing, so the card looked idle and could be clicked repeatedly. - Add an optional `isProcessing` prop (default false). - While processing: show a Loader2 spinner, set `aria-busy`, dim and disable the card (pointer-events-none), and guard the click handler so the action cannot be triggered twice. - Restore the normal interactive state when processing completes. - Keep the colorblind-safe status badges intact. Adds BillingProfileCard.test.tsx covering normal/processing states, duplicate activation prevention, status badges, type label and dark theme. Closes Grainlify#273
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds optional
isProcessingprop: spinner viaLoader2(role=status),aria-busy, disabled controls (pointer-events-none/reducedopacity), and click guard. Reuses the established pattern fromApplicationCard.tsx.Verification:
typecheck: OKBillingProfileCard.test.tsx: 7/7 greenCloses #273