feat(forms): bound SearchPage query length with accessible feedback (#271)#425
Open
jd5073356-max wants to merge 1 commit into
Open
feat(forms): bound SearchPage query length with accessible feedback (#271)#425jd5073356-max wants to merge 1 commit into
jd5073356-max wants to merge 1 commit into
Conversation
…rainlify#271) The dashboard search input had no length bound or feedback, so very long pasted queries were silently debounced and sent to search. - Add maxLength={100} to the search input. - Show an aria-live character counter as the query approaches the limit, with a "Character limit reached" message at the cap. - Trim leading/trailing whitespace before searching (debounce unchanged). - Extend SearchPage tests: maxLength attribute, counter near/at the limit, trimmed query matching, and whitespace-only handling. Closes Grainlify#271
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
MAX_SEARCH_LENGTH=100withmaxLength, anaria-live="polite"counter (visible at >=80 chars), and whitespace trimming before dispatch while preserving the existing debounce.Verification:
typecheck: OKpnpm test -- SearchPage: 15/15 greenCloses #271