Skip to content

fix: add link-check ignore patterns for localhost and private URLs #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GrammaTonic merged 1 commit into from
Mar 1, 2026
Merged

fix: add link-check ignore patterns for localhost and private URLs #1129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .markdown-link-check.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,12 @@
{
"pattern": "^https://github\\.com/.*/wiki/"
},
{
"pattern": "^https://github\\.com/users/.*/projects/"
},
{
"pattern": "^https?://localhost[:/]"
Copy link

@gemini-code-assist gemini-code-assist bot Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The regular expression ^https?://localhost[:/] is a bit restrictive. It will not match a URL that is just http://localhost without a trailing port or path. Using a word boundary (\b) would make this pattern more robust, correctly matching localhost as a whole word in various URL formats (e.g., with a port, with a path, or standalone) while avoiding matches for hostnames that merely start with localhost.

Suggested change
"pattern": "^https?://localhost[:/]"
"pattern": "^https?://localhost\\b"

},
{
"pattern": "^#"
}
Expand Down