Conversation
- PHASE2_IMPLEMENTATION_SUMMARY.md: fix relative paths to tests/integration/ (./tests → ../../tests, resolves from docs/features/ correctly) - PROMETHEUS_TIMELINE_VISUAL.md: replace absolute /plan/ path with relative ../../plan/ path - prometheus-metrics-phase1.md: replace dead SUPPORT.md link with CONTRIBUTING.md - PERFORMANCE_OPTIMIZATIONS.md: remove dead PARALLEL_NPM_RESULTS.md link (rejected feature, results file never created)
* fix: harden docs-validation and auto-sync-docs workflows - Fix critical bug: super-linter FILTER_REGEX_INCLUDE/EXCLUDE used glob syntax instead of regex, linter was effectively scanning zero files. Changed to proper regex: (docs|wiki-content)/.* and docs/archive/.* - Fix link-check silently swallowing failures: remove || true from markdown-link-check invocations so broken links actually fail the build - Pin markdown-link-check to v3.14.2 to prevent supply chain attacks - Add .markdown-link-check.json config with retry-on-429, timeout, and ignore patterns for flaky URLs (actions/runs, settings, wiki pages) - Pin super-linter to SHA (12150456) instead of mutable v7 tag - Add permissions block (contents: read, statuses: write) to docs-validation.yml to prevent overly broad default token scope - Add concurrency group to cancel in-progress runs on rapid PR pushes - Optimize checkout: fetch-depth 1 plus targeted base SHA fetch - Fix patch diff: use PR base SHA instead of always diffing origin/main - Integrate scripts/check-docs-structure.sh into CI pipeline - Fix VALIDATE_MD to VALIDATE_MARKDOWN env var for super-linter v7 - Apply same fixes to auto-sync-docs.yml (identical copy-pasted bugs) * fix: address Gemini review comments on link-check config - Remove api.github.com from text/html header rule since the GitHub API serves JSON and would return errors with Accept: text/html - Remove 301/302 from aliveStatusCodes since markdown-link-check follows redirects by default and including them could mask broken destinations
Add ignore patterns for localhost URLs (documentation examples not reachable in CI) and GitHub user project board URLs (private/404 in CI). Fixes docs-validation failure on PR #1128.
Replace super-linter with markdownlint-cli2-action for ~95% faster Markdown linting. Add workflow_dispatch trigger for manual runs.
- Add continue-on-error to all validation steps so every check runs - Capture output from structure, outdated refs, and link checks - Generate GITHUB_STEP_SUMMARY with status table and per-check details - Include 'How to fix' guidance for each failure type - Final gate step fails the job if any check failed
Fix all validate-docs CI failures: auto-fix 656+ markdownlint errors, disable noisy rules, fix heading structure, repair dead links, strengthen link-check config. 0 errors across 46 files.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request promotes the latest integrated changes from the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request promotes a series of commits from develop to main, primarily focused on documentation improvements, CI hardening, and new configurations. The changes largely enhance readability and fix links. However, I've identified several instances of incorrect numbering in ordered lists within the markdown documentation. These should be corrected to ensure clarity and correctness.
| 2. **Optimize npm patching** - Single consolidated patch operation | ||
| 3. **Parallel test execution** - Run tests during/after builds | ||
| 4. **Dependency caching in CI/CD** - Cache apt, npm, pip packages | ||
| 5. **Version pinning** - Reproducible builds, better caching |
There was a problem hiding this comment.
The numbering in this list is incorrect. It should be sequential (7, 8, 9, 10) instead of restarting from 2.
| 2. **Optimize npm patching** - Single consolidated patch operation | |
| 3. **Parallel test execution** - Run tests during/after builds | |
| 4. **Dependency caching in CI/CD** - Cache apt, npm, pip packages | |
| 5. **Version pinning** - Reproducible builds, better caching | |
| 7. **Optimize npm patching** - Single consolidated patch operation | |
| 8. **Parallel test execution** - Run tests during/after builds | |
| 9. **Dependency caching in CI/CD** - Cache apt, npm, pip packages | |
| 10. **Version pinning** - Reproducible builds, better caching |
| 2. **Advanced caching strategies** - Remote cache, registry cache | ||
| 3. **Resource limit tuning** - CPU/memory optimization | ||
| 4. **Startup time optimization** - Lazy initialization patterns | ||
| 5. **Alternative base images** - Alpine, distroless evaluation |
There was a problem hiding this comment.
The numbering in this list is incorrect. It should be sequential (12, 13, 14, 15) instead of restarting from 2.
| 2. **Advanced caching strategies** - Remote cache, registry cache | |
| 3. **Resource limit tuning** - CPU/memory optimization | |
| 4. **Startup time optimization** - Lazy initialization patterns | |
| 5. **Alternative base images** - Alpine, distroless evaluation | |
| 12. **Advanced caching strategies** - Remote cache, registry cache | |
| 13. **Resource limit tuning** - CPU/memory optimization | |
| 14. **Startup time optimization** - Lazy initialization patterns | |
| 15. **Alternative base images** - Alpine, distroless evaluation |
| 2. **Large image sizes:** 2-4GB per variant | ||
| 3. **Slow builds:** 5-9 minutes for Chrome variants | ||
| 4. **Duplicate installations:** Playwright installs browsers when Chrome exists |
There was a problem hiding this comment.
The numbering in this list is incorrect. It should be sequential (6, 7, 8) instead of restarting from 2.
| 2. **Large image sizes:** 2-4GB per variant | |
| 3. **Slow builds:** 5-9 minutes for Chrome variants | |
| 4. **Duplicate installations:** Playwright installs browsers when Chrome exists | |
| 6. **Large image sizes:** 2-4GB per variant | |
| 7. **Slow builds:** 5-9 minutes for Chrome variants | |
| 8. **Duplicate installations:** Playwright installs browsers when Chrome exists |
| 2. **Documentation:** Missing inline comments for complex operations | ||
| 3. **Health check tuning:** 60s start period could be optimized |
There was a problem hiding this comment.
The numbering in this list is incorrect. It should be sequential (10, 11) instead of restarting from 2.
| 2. **Documentation:** Missing inline comments for complex operations | |
| 3. **Health check tuning:** 60s start period could be optimized | |
| 10. **Documentation:** Missing inline comments for complex operations | |
| 11. **Health check tuning:** 60s start period could be optimized |
| 2. **Remote cache** - Share cache across CI/CD runners | ||
| 3. **Registry cache** - Use GitHub Container Registry as cache backend | ||
| 4. **Custom runner distribution** - Pre-built runner binary |
There was a problem hiding this comment.
The numbering in this list is incorrect. It should be sequential (5, 6, 7) instead of restarting from 2. Also, the number 4 is repeated.
| 2. **Remote cache** - Share cache across CI/CD runners | |
| 3. **Registry cache** - Use GitHub Container Registry as cache backend | |
| 4. **Custom runner distribution** - Pre-built runner binary | |
| 5. **Remote cache** - Share cache across CI/CD runners | |
| 6. **Registry cache** - Use GitHub Container Registry as cache backend | |
| 7. **Custom runner distribution** - Pre-built runner binary |
| 1. **Cache size monitoring** - GitHub Actions 10GB cache limit | ||
| - **Current usage:** Unknown (need to monitor) | ||
| - **Action:** Add cache size reporting to workflow | ||
| 3. **Cache eviction** - 7-day limit may affect infrequent builds | ||
|
|
||
| 2. **Cache eviction** - 7-day limit may affect infrequent builds | ||
| - **Mitigation:** Regular scheduled builds to keep cache warm |
There was a problem hiding this comment.
The numbering in this list is incorrect. It should be sequential (2, 3) instead of restarting from 1.
| 1. **Cache size monitoring** - GitHub Actions 10GB cache limit | |
| - **Current usage:** Unknown (need to monitor) | |
| - **Action:** Add cache size reporting to workflow | |
| 3. **Cache eviction** - 7-day limit may affect infrequent builds | |
| 2. **Cache eviction** - 7-day limit may affect infrequent builds | |
| - **Mitigation:** Regular scheduled builds to keep cache warm | |
| 2. **Cache size monitoring** - GitHub Actions 10GB cache limit | |
| - **Current usage:** Unknown (need to monitor) | |
| - **Action:** Add cache size reporting to workflow | |
| 3. **Cache eviction** - 7-day limit may affect infrequent builds | |
| - **Mitigation:** Regular scheduled builds to keep cache warm |
| - Verifies no port conflicts | ||
|
|
||
| 7. **tests/integration/PHASE2_TESTING_GUIDE.md** (300+ lines) | ||
| 2. **tests/integration/PHASE2_TESTING_GUIDE.md** (300+ lines) |
There was a problem hiding this comment.
The numbering for this list item is incorrect. It should be 7. to follow the preceding item numbered 6..
| 2. **tests/integration/PHASE2_TESTING_GUIDE.md** (300+ lines) | |
| 7. **tests/integration/PHASE2_TESTING_GUIDE.md** (300+ lines) |
|
|
||
| <!-- Security Configuration doc not available. Link removed for CI/CD compliance. --> | ||
| 4. **[Production Deployment](Production-Deployment.md)** - Production checklist | ||
| 1. **[Production Deployment](Production-Deployment.md)** - Production checklist |
There was a problem hiding this comment.
The numbering in this list is incorrect. This item should be numbered 3. to maintain sequential order.
| 1. **[Production Deployment](Production-Deployment.md)** - Production checklist | |
| 3. **[Production Deployment](Production-Deployment.md)** - Production checklist |
Add /discussions URL ignore pattern to fix validate-docs CI failures
1 participant
Promote develop to main
Summary
Promote 6 commits from
developintomaincovering docs-validation hardening, CI improvements, and documentation fixes.Commits included
26f6e6c3371ac13983b2ac9a28f8872e0c74ef1df0Merge Strategy
Checklist