security: add FLAG_IMMUTABLE to PendingIntents#95
Open
Sec0xEd wants to merge 1 commit intoGrapheneOS:mainfrom
Open
security: add FLAG_IMMUTABLE to PendingIntents#95Sec0xEd wants to merge 1 commit intoGrapheneOS:mainfrom
Sec0xEd wants to merge 1 commit intoGrapheneOS:mainfrom
Conversation
Add FLAG_IMMUTABLE to PendingIntents in ActionServiceImpl and UIIntentsImpl to prevent potential PendingIntent hijacking attacks. Starting from Android 12, PendingIntents should specify mutability explicitly. These PendingIntents don't require modification by external apps, so FLAG_IMMUTABLE is the appropriate choice. References: - https://developer.android.com/reference/android/app/PendingIntent#FLAG_IMMUTABLE - https://developer.android.com/about/versions/12/behavior-changes-12#pending-intent-mutability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
FLAG_IMMUTABLEto PendingIntents inActionServiceImplandUIIntentsImplto prevent potential PendingIntent hijacking attacks.Problem
Two PendingIntents were created with
FLAG_UPDATE_CURRENTalone, without specifying mutability:ActionServiceImpl.makeStartActionPendingIntent()UIIntentsImpl.getPendingIntentForLowStorageNotifications()Starting from Android 12, apps must explicitly specify the mutability of PendingIntents. Without
FLAG_IMMUTABLE, a malicious app could potentially modify the PendingIntent before it's delivered, leading to:Solution
Added
FLAG_IMMUTABLEto both PendingIntents since they: