fixup! fix DNS leak in VPN lockdown mode when VPN is down#15
Open
liamsmith827 wants to merge 1 commit intoGrapheneOS:16-qpr2from
Open
fixup! fix DNS leak in VPN lockdown mode when VPN is down#15liamsmith827 wants to merge 1 commit intoGrapheneOS:16-qpr2from
liamsmith827 wants to merge 1 commit intoGrapheneOS:16-qpr2from
Conversation
When a VPN app is doing DNS with its own tunnel servers, protecting that traffic can result in the tunnel and tunnel DNS server IP addresses leaking. Any VPN app that is setting tunnel DNS servers that aren't reachable through the tunnel is already broken, as apps would be unable to do DNS when leak blocking is enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a VPN app is doing DNS with its own tunnel servers, protecting that traffic can result in the tunnel and tunnel DNS server IP addresses leaking. Any VPN app that is setting tunnel DNS servers that aren't reachable through the tunnel is already broken, as apps would be unable to do DNS when leak blocking is enabled.
GrapheneOS/os-issue-tracker#5273