Desktop: Add fullscreen window mode #3625
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timon-schelling
changed the title
timon-schelling
force-pushed
the
desktop-f11-for-fullscreen
branch
from
f08bd09 to
f7fa350
Compare
Member
Author
|
@Keavon I don't think you need to do a full review. Desktop changes are really strait forward. But a opinion on macro changes would be helpful. |
timon-schelling
force-pushed
the
desktop-f11-for-fullscreen
branch
from
f7fa350 to
af6a308
Compare
Member
|
Keavon
changed the title
timon-schelling
force-pushed
the
desktop-f11-for-fullscreen
branch
2 times, most recently
from
31e4c43 to
d7cef15
Compare
timon-schelling
force-pushed
the
desktop-f11-for-fullscreen
branch
from
d7cef15 to
c6e70d9
Compare
Keavon
changed the title
timon-schelling
force-pushed
the
desktop-f11-for-fullscreen
branch
from
a84bb6a to
a0c8e8d
Compare
Keavon
requested changes
Jan 17, 2026
Comment on lines
+30
to
+31
| // TODO: Fix this failing to load the correct data (and throwing a console warning) because it's occurring before the value has been supplied during initialization from the JS `initAfterFrontendReady` | ||
| let keyboard_platform = GLOBAL_PLATFORM.get().copied().unwrap_or_default().as_keyboard_platform_layout(); |
Member
There was a problem hiding this comment.
@timon-schelling this is a regression. Here's the error mentioned in this TODO comment I added for you:
This will work when the warning is gone and you can use the web version on Mac and see Window > Fullscreen has the Mac-specific shortcut instead of F11 which it currently shows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f11 is not usable on mac for this, browsers use cmd + strg + f.
now opted for cmd + strg + f on mac.
Closes #3510