Add RFC for the attribute system - #4406
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 1 file
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Performance Benchmark Results
|
f0af96a to
00e40b4
Compare
Performance Benchmark Results
|
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Performance Benchmark Results
|
Performance Benchmark Results
|
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
Performance Benchmark Results
|
Performance Benchmark Results
|
Performance Benchmark Results
|
| # Summary | ||
|
|
||
| Give every item flowing through the graph a set of named, typed attributes | ||
| next to its primary `element` value. Attributes are stored as a packed |
There was a problem hiding this comment.
I'm not sure it is necessary or desirable to have a primary element. For example you might wish to store a list containing x: f64 and y: f64 as attributes. It would not make sense to set one of these as the primary « element » ?
I think your approach would work just as well with the primary element removed. It would perhaps even simplify it somewhat.
There was a problem hiding this comment.
I agree with this somewhat, the asymmetry is definitely weird, I think mainly inherited from the "Old" Table type.
If we go all in on "dynamic" types I think we could get inspiration from NuShell's
structured data types.
| A unit value component means the edge exists and carries only its | ||
| attributes (`_: ()` still means no edge at all). The name enters the | ||
| graph at a source node holding the constant text input, whose output | ||
| type is filled at graph compile time, where user-supplied names join |
There was a problem hiding this comment.
A user may currently choose to give a dynamic name (such as the current animation time as a string). Would this be forbidden under this proposal?
| fn set_attribute<T, A, Y>( | ||
| _: impl Ctx, | ||
| element: T, | ||
| (_, attr): ((), Attr<Custom<A, Y>>), |
There was a problem hiding this comment.
What is A and Y? What is Custom?
| inner level from outside is an explicit map/enter construct, so "set on | ||
| the parent" and "map over the children" are visibly different graphs. |
There was a problem hiding this comment.
It is surely useful to allow mapping over children after constructing the list? For example, I might have a « Trace Raster » node which converts a raster image into several shapes. I would then like to give each shape its own opacity.
How could this be accomplished within this system?
| index and produces that copy's values. `level_extent = count` declares | ||
| the size of the new level, and the compiler derives the structural parts | ||
| from that one declaration: the multiplication with the carrier's extent, | ||
| and the index decomposition that routes an output lane to the right copy | ||
| and content item. The `emit(...)` tail marks the one-lane form and |
There was a problem hiding this comment.
I find this syntax quite hard to read and reason about. What is the motivation over just explicitly writing a for index in 0..count ?
| Switch takes two lazy inputs and returns one of them, for any carrier, | ||
| without an implementations list: |
| the default). A name that wants a distinguished unset declares an | ||
| `Option` value type on its marker. | ||
|
|
||
| Fields are `Copy`, and larger payloads go behind a pointer-sized field. |
There was a problem hiding this comment.
What would own the larger payloads? Is it necessary to clone them when cloning a table?
3 participants
No description provided.