Skip to content

Rename HighlightDescriptor BoundaryMaxSize to BoundaryMaxScan #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stefanminkov wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rename HighlightDescriptor BoundaryMaxSize to BoundaryMaxScan #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/Nest/DSL/Search/HighlightDescriptor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ public interface IHighlightRequest
[JsonProperty("fragment_offset")]
int? FragmentOffset { get; set; }

[JsonProperty("boundary_max_size")]
int? BoundaryMaxSize { get; set; }
[JsonProperty("boundary_max_scan")]
int? BoundaryMaxScan { get; set; }

[JsonProperty("encoder")]
string Encoder { get; set; }
Expand All @@ -56,7 +56,7 @@ public class HighlightRequest : IHighlightRequest
public string TagsSchema { get; set; }
public int? NumberOfFragments { get; set; }
public int? FragmentOffset { get; set; }
public int? BoundaryMaxSize { get; set; }
public int? BoundaryMaxScan { get; set; }
public string Encoder { get; set; }
public string Order { get; set; }
public Dictionary<PropertyPathMarker, IHighlightField> Fields { get; set; }
Expand All @@ -81,7 +81,7 @@ public class HighlightDescriptor<T> : IHighlightRequest

int? IHighlightRequest.FragmentOffset { get; set; }

int? IHighlightRequest.BoundaryMaxSize { get; set; }
int? IHighlightRequest.BoundaryMaxScan { get; set; }

string IHighlightRequest.Encoder { get; set; }

Expand Down Expand Up @@ -177,9 +177,9 @@ public HighlightDescriptor<T> BoundaryCharacters(string boundaryCharacters)
Self.BoundaryChars = boundaryCharacters;
return this;
}
public HighlightDescriptor<T> BoundaryMaxSize(int boundaryMaxSize)
public HighlightDescriptor<T> BoundaryMaxScan(int boundaryMaxSize)
{
Self.BoundaryMaxSize = boundaryMaxSize;
Self.BoundaryMaxScan = boundaryMaxSize;
return this;
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/Tests/Nest.Tests.Unit/Search/Highlight/HighlightTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public void TestHighlight()
.Size(10)
.Highlight(h => h
.BoundaryCharacters(".,!? \t\n")
.BoundaryMaxSize(20)
.BoundaryMaxScan(20)
.Encoder("html")
.FragmentOffset(0)
.FragmentSize(3)
Expand Down