Conversation
LycoKodo
requested changes
Jul 20, 2025
|
|
||
| --- | ||
|
|
||
| ### Motivation |
Contributor
There was a problem hiding this comment.
feature requests are usually used to request for a feature, before its written :D, so maybe keep this more like "why this is a good idea", rather than "what motivated u to create it".
also environment shouldnt be necessary
| - [ ] I **HAVE** added unit tests for any new functionality or bug fixes (if applicable). | ||
| - [ ] I **HAVE** not broken the continuous integration build. | ||
| - [ ] I **HAVE** avoided major architectural changes unless previously discussed. | ||
|
|
Contributor
There was a problem hiding this comment.
add "i have adhered to GravLib naming conventions" or smthing similar. Refer to atlassian's guide on enterprise level rust syntax
Contributor
|
@venus-beetroot can you please implement my requested changes if you are happy about it? Also please update description. |
- added conditions in the checklist for V5 hardware - added a 'Breaking Changes' section - added requirement for describing/including outcome of tests and/or changes with a screenshot - if performance changes were impacted, needed to state
- added V5 relevance - Added Proposed Solution with code example placeholder - Added Acceptance Criteria section for clear requirements - Better structured with logical flow from problem → solution → impact → timeline - Implementation Impact checklist covering performance, memory, and hardware compatibility - Priority/Urgency related to competition timelines - Specific Hardware field in the environment section - Renamed "Current Implementation" to "Alternatives Considered"
removed: - priority/urgency - environment - related code/logs
- removed 'What was Changed' - removed 'Breaking Changes' - removed 'Related Issues/PRs' - changed 'Description' to 'Summary' - added 'Motivation'
LycoKodo
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.