Skip to content

Fix/auth manager http2 ping keepalive#16

Open
etgraylog wants to merge 5 commits into
mainfrom
fix/auth-manager-http2-ping-keepalive
Open

Fix/auth manager http2 ping keepalive#16
etgraylog wants to merge 5 commits into
mainfrom
fix/auth-manager-http2-ping-keepalive

Conversation

@etgraylog

@etgraylog etgraylog commented May 26, 2026

Copy link
Copy Markdown

Notes for Reviewers

This PR supercedes PR Graylog2/collector-sidecar#544 to resolve issue #13 .

Summary

  • Populates http.Transport.HTTP2 on auth.Manager's default HTTP client with SendPingTimeout=30s and PingTimeout=10s
  • Half-dead HTTP/2 connections (upstream silently dropped, no RST) are evicted within ~40s instead of waiting for the kernel's ~11-minute TCP keepalive ladder
  • Healthy traffic is unaffected — any inbound frame resets the SendPingTimeout timer
  • A caller-supplied HTTPClient in ManagerConfig is left untouched

Test plan

  • go test ./superv/auth/... passes

  • Confirm GODEBUG=http2debug=2 shows Transport sending health check at the configured interval against a live Graylog server

  • The commit history must be preserved - please use the rebase-merge or standard merge option instead of squash-merge

  • Sync up with the author before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants