Fix/auth manager http2 ping keepalive#16
Open
etgraylog wants to merge 5 commits into
Open
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR supercedes PR Graylog2/collector-sidecar#544 to resolve issue #13 .
Summary
http.Transport.HTTP2onauth.Manager's default HTTP client withSendPingTimeout=30sandPingTimeout=10sSendPingTimeouttimerHTTPClientinManagerConfigis left untouchedTest plan
go test ./superv/auth/...passesConfirm
GODEBUG=http2debug=2showsTransport sending health checkat the configured interval against a live Graylog serverThe commit history must be preserved - please use the rebase-merge or standard merge option instead of squash-merge
Sync up with the author before merging