Skip to content

Solution (#26635): LDAP paginated search may cause invalid warnings about duplicates#26683

Open
TFGSUMIT wants to merge 1 commit into
Graylog2:masterfrom
TFGSUMIT:fix/issue-26635
Open

Solution (#26635): LDAP paginated search may cause invalid warnings about duplicates#26683
TFGSUMIT wants to merge 1 commit into
Graylog2:masterfrom
TFGSUMIT:fix/issue-26635

Conversation

@TFGSUMIT

Copy link
Copy Markdown

This PR addresses the issue of LDAP paginated search causing invalid warnings about duplicates in large directories. It introduces a Server-Side Sort control to the paginated search, ensuring that search results are sorted and de-duplicated correctly.

Changes Made:

  • Modified the UnboundLDAPConnector.searchPaginated() method to add a Server-Side Sort control to the LDAP search request.
  • Updated the EnterpriseUnboundLDAPConnector.loadMemberResolver() method to perform the paginated search using the modified UnboundLDAPConnector.searchPaginated() method.

Testing Instructions:

  1. Run the main.py script with a large LDAP directory to test the fix.
  2. Verify that duplicates are no longer present in the search results.
  3. Test the fix with different sort keys and page sizes to ensure that it works correctly in all scenarios.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


GitHub Agent seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants