Manage Kotlin dependencies#26684
Open
thll wants to merge 6 commits into
Open
Conversation
Materialize the KCL config objects as locals (ConfigsBuilder accessors create a new instance per call) and add a no-op hook so integration tests can tune KCL coordination timings. Also extract the KCL application name derivation into a package-private method so tests can pre-seed the lease table without duplicating the format. No production behavior change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Runs Floci (MIT-licensed, LocalStack-API-compatible) with Kinesis and DynamoDB. LocalStack itself is not an option: its free tier prohibits commercial use since March 2026 and the image requires an auth token. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Boots the KCL Scheduler end-to-end against a local Kinesis+DynamoDB emulator and verifies a record round-trip in a few seconds. KCL coordination timings are tuned via the test seam, and the consumer runs in KCL's 2.x-compatible lease assignment mode because the 3.x default requires worker-utilization metrics and EC2 platform detection that do not exist in a local test environment. The lease table is pre-seeded with an unowned TRIM_HORIZON lease to bypass KCL's random 1-30s initial lease-sync jitter; there is deliberately no fallback, so if KCL ever stops honoring the pre-seeded lease the test fails by timeout instead of silently passing slower. Guards the schema-registry-serde exclusion and future amazon-kinesis-client upgrades. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
thll
marked this pull request as ready for review
July 17, 2026 11:20
Contributor
Author
|
@danotorrey, if you have the capacity, it would be great if you could have a look at the Kinesis client related changes. |
danotorrey
approved these changes
Jul 17, 2026
danotorrey
left a comment
danotorrey
left a comment
Contributor
There was a problem hiding this comment.
@thll The Kinesis changes LGTM and tests successfully. Thanks also for the IT. That's a nice addition to exercise the KCL in a self-contained way.
luk-kaminski
self-requested a review
July 20, 2026 12:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds dependency management for Kotlin, which is used transitively by the graylog2-server module but also required by the enterprise plugin.
By managing the Kotlin dependencies, we can ensure a consistent version.
Also excludes the dependencies required for Glue schema serde support from the Kinesis client. We are not using that functionality and it and rather relying on upwards compatibility, we exclude it. To make sure that the Kinesis consumer is still functional, I've added a very basic integration test.
Dependency tree:
before:
after:
/prd https://github.com/Graylog2/graylog-plugin-enterprise/pull/14880
/nocl not user-facing