Skip to content

Extend Kafka transport integration tests#26686

Open
bernd wants to merge 3 commits into
masterfrom
add/kafka-compression-tests
Open

Extend Kafka transport integration tests#26686
bernd wants to merge 3 commits into
masterfrom
add/kafka-compression-tests

Conversation

@bernd

@bernd bernd commented Jul 16, 2026

Copy link
Copy Markdown
Member

/nocl additional tests

@bernd
bernd requested a review from a team July 16, 2026 15:03
bernd added 2 commits July 17, 2026 10:05
Adding tests for gzip, snappy, lz4, and zstd compression options.
Should be use to annotate tests which run multiple seconds.
@bernd
bernd force-pushed the add/kafka-compression-tests branch from ebe6562 to 6feadbe Compare July 17, 2026 08:05

@thll thll left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just spotted two unused imports.

import org.graylog2.plugin.system.SimpleNodeId;
import org.graylog2.shared.SuppressForbidden;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.Test;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused

Suggested change
import org.junit.jupiter.api.Test;

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fixed. (force pushed so we can use rebase+merge)

import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.junit.jupiter.params.ParameterizedTest;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused

Suggested change
import org.junit.jupiter.params.ParameterizedTest;

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fixed. (force pushed so we can use rebase+merge)

@bernd
bernd force-pushed the add/kafka-compression-tests branch from 6feadbe to 80909e5 Compare July 20, 2026 12:51
@bernd
bernd requested a review from thll July 20, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants