Fix admin certificate regeneration/usage in data node system index reindex#26687
Merged
Conversation
todvora
approved these changes
Jul 20, 2026
todvora
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The admin certificate was used after its expiry because the refresh of the transport was not triggered correctly.
This PR fixes this and swaps the transport with a new one with a fresh certificate on demand if the certificate would be expired.
Motivation and Context
/nocl fixes error introduced during development
How Has This Been Tested?
reduced lifetime of certificate, made two calls to AdminIndicesAdapter so the second call would have used an expired certificate, made sure that a new one was minted
Screenshots (if appropriate):
Types of changes
Checklist: