Skip to content

Fix admin certificate regeneration/usage in data node system index reindex#26687

Merged
todvora merged 2 commits into
masterfrom
fix/admin-cert-expiry
Jul 20, 2026
Merged

Fix admin certificate regeneration/usage in data node system index reindex#26687
todvora merged 2 commits into
masterfrom
fix/admin-cert-expiry

Conversation

@moesterheld

Copy link
Copy Markdown
Contributor

Description

The admin certificate was used after its expiry because the refresh of the transport was not triggered correctly.
This PR fixes this and swaps the transport with a new one with a fresh certificate on demand if the certificate would be expired.

Motivation and Context

/nocl fixes error introduced during development

How Has This Been Tested?

reduced lifetime of certificate, made two calls to AdminIndicesAdapter so the second call would have used an expired certificate, made sure that a new one was minted

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have requested a documentation update.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@todvora todvora left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@todvora
todvora merged commit 6e05301 into master Jul 20, 2026
23 checks passed
@todvora
todvora deleted the fix/admin-cert-expiry branch July 20, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants