Move tests for global helper functions to test_utils.py#1356
Closed
devpatel-1 wants to merge 2 commits into
Closed
Move tests for global helper functions to test_utils.py#1356devpatel-1 wants to merge 2 commits into
devpatel-1 wants to merge 2 commits into
Conversation
Moved TestGetIocType, TestIsValidIpv4, and TestIsValidCIDR from test_extraction_utils.py to test_utils.py as they test functions from greedybear/utils.py not extraction utils. Fixes #1352
94ea5de to
2c346d2
Compare
regulartim
reviewed
May 21, 2026
| @@ -1,11 +1,290 @@ | |||
| # This file is a part of GreedyBear https://github.com/honeynet/GreedyBear | |||
| # Copyright (C) 2021-2022 CSIRT Gadgets Foundation | |||
regulartim
reviewed
May 21, 2026
| is_valid_ipv4, | ||
| ) | ||
|
|
||
| from .base import CustomTestCase |
Member
There was a problem hiding this comment.
That's not the correct path, so the code in your PR is not executable. This means you never ran the suite locally after the move. Or do you have another explanation?
Member
|
Hey @devpatel-1 ! You did not answer my feedback on your PR and just closed it. That's not how I expect contributors to collaborate. I'll unassign you from the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved TestGetIocType, TestIsValidIpv4, and TestIsValidCIDR from test_extraction_utils.py to test_utils.py as they test functions from greedybear/utils.py not extraction utils.
Fixes #1352
Description
Please include a short summary of the change. Don't just paste LLM output here.
Related issues
Please add related issues: the issues you are trying to solve as well as other issues that are important in the context of this pull request.
Type of change
Checklist
Please complete this checklist carefully. It helps guide your contribution and lets maintainers verify that all requirements are met.
Formalities
<feature name>. Closes #999develop.develop.Docs and tests
Ruff) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.GUI changes
Ignore this section if you did not make any changes to the GUI.
Review process