Skip to content

Fix/1351 improve 404 page#1361

Merged
regulartim merged 2 commits into
GreedyBear-Project:developfrom
suvani-ctrl:fix/1351-improve-404-page
May 24, 2026
Merged

Fix/1351 improve 404 page#1361
regulartim merged 2 commits into
GreedyBear-Project:developfrom
suvani-ctrl:fix/1351-improve-404-page

Conversation

@suvani-ctrl
Copy link
Copy Markdown
Contributor

@suvani-ctrl suvani-ctrl commented May 21, 2026

Description

Improved the NotFoundPage layout and user experience by resolving three core structural and navigation
limitations:
Fixed Footer Alignment:
Implemented an 80vh min-height property to securely lock the footer to the bottom of the viewport, eliminating high floating on short viewports.
Added Failed Path Display:
Implemented React Router's useLocation hook to dynamically render the exact broken URL path (location.pathname) so users have clear context on what failed.
Enhanced Navigation Recovery:
Replaced the single homepage link dead-end with a clean Reactstrap ButtonGroup, giving users direct paths to Home, Feeds, and the Dashboard.

Related Issues

Closes #1351
The component was also refactored to remove all debug logs and console.log statements, ensuring the final code remains completely clean.

Updated 404 page

screenshot_greedy_bear_404_not_found

Type of change

  • [ X] Bug fix (non-breaking change which fixes an issue).
  • [] New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Chore (refactoring, dependency updates, CI/CD changes, code cleanup, docs-only changes).

Checklist

Please complete this checklist carefully. It helps guide your contribution and lets maintainers verify that all requirements are met.

Formalities

  • I have read and understood the rules about how to Contribute to this project.
  • I chose an appropriate title for the pull request in the form: <feature name>. Closes #999
  • My branch is based on develop.
  • The pull request is for the branch develop.
  • I have reviewed and verified any LLM-generated code included in this PR.

Docs and tests

  • I documented my code changes with docstrings and/or comments.
  • I have checked if my changes affect user-facing behavior that is described in the docs. If so, I also included an update to the wiki in the description of this PR.
  • Linter (Ruff) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.
  • [] I have added tests for the feature/bug I solved.
  • All the tests gave 0 errors.

GUI changes

Ignore this section if you did not make any changes to the GUI.

  • I have provided a screenshot of the result in the PR.
  • I have created new frontend tests for the new component or updated existing ones.

@suvani-ctrl suvani-ctrl marked this pull request as draft May 21, 2026 17:22
@suvani-ctrl suvani-ctrl force-pushed the fix/1351-improve-404-page branch from 15c6667 to 8c4bf30 Compare May 21, 2026 17:34
@suvani-ctrl suvani-ctrl marked this pull request as ready for review May 21, 2026 17:36
@suvani-ctrl
Copy link
Copy Markdown
Contributor Author

suvani-ctrl commented May 21, 2026

I opened a Draft PR to develop for #1351. I used Bootstrap flex alignment paired with an inline style of minHeight: "80vh" to center the content and force the high footer down to the bottom of the screen. I also added the useLocation hook to dynamically display the broken URL path, and replaced the single home link with a button group for Home, Feeds, and Dashboard that could give users clear exit options/ redirections .I formatted the code using Prettier (npm run formatter) to matche the repository guidelines and it shows it passed the automated CI formatting checks.

All frontend tests pass cleanly on npm test , except for a pre-existing flaky date test in NewsWidget.

@regulartim regulartim marked this pull request as draft May 21, 2026 19:12
@regulartim
Copy link
Copy Markdown
Member

I opened a Draft PR to develop for #1351.

I'm a little confused. This PR was not a draft, so I converted it to one. I hope this is fine for you.

except for a pre-existing flaky date test in NewsWidget.

Oh, if you found a flaky test, could you please open an issue for that? :)

Your screenshot looks good, I like the decisions you made. Polish the PR a bit (add description, remove console.log, etc.) and I think it is ready for review! If your done, just mark it as "ready to review" and I'll take a look.

@suvani-ctrl suvani-ctrl force-pushed the fix/1351-improve-404-page branch from 8c4bf30 to 73dc143 Compare May 21, 2026 19:47
@suvani-ctrl suvani-ctrl marked this pull request as ready for review May 21, 2026 19:57
@suvani-ctrl suvani-ctrl force-pushed the fix/1351-improve-404-page branch from 73dc143 to 51a1ead Compare May 21, 2026 20:00
@suvani-ctrl
Copy link
Copy Markdown
Contributor Author

I made the changes ! Can you check please and let me know if they are okay now ! @regulartim

Copy link
Copy Markdown
Member

@regulartim regulartim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! :)

@regulartim regulartim merged commit 8443fa6 into GreedyBear-Project:develop May 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants