Alias experiment#1
Open
PavelAndrianov wants to merge 13 commits into
Open
Conversation
PavelAndrianov
commented
Mar 11, 2021
PavelAndrianov
commented
Mar 11, 2021
| return new UsageState(pWrappedState, this); | ||
| } | ||
|
|
||
| private UsageState createState( |
Collaborator
Author
There was a problem hiding this comment.
protected? Не понадобилось переопределять?
PavelAndrianov
commented
Mar 11, 2021
PavelAndrianov
commented
Mar 11, 2021
|
|
||
| if (variableBindingRelation.containsKey(entry.getKey())) { | ||
| if (!variableBindingRelation.get(entry.getKey()).equals(entry.getValue())) { | ||
| throw new Error("Cannot handle it yet"); |
Collaborator
Author
There was a problem hiding this comment.
UnsupportedOperationException. И сообщение нужно поприличнее, то есть явно написать, что не поддерживается. Это вы видите, что за if, а пользователь не должен искать место в коде, а по сообщению понять, что не поддерживаетс.
PavelAndrianov
commented
Mar 11, 2021
| } else if (statement instanceof CFunctionCallStatement) { | ||
| fcExpression = ((CFunctionCallStatement) statement).getFunctionCallExpression(); | ||
| } else { | ||
| return ImmutableSet.of(); |
Collaborator
Author
There was a problem hiding this comment.
Это правильно? Раньше не возвращались только ссылки. Сейчас это уже состояния.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR just for discussion