Conversation
This requires the use of fitsio, which instantly complicates things because we must support non-ascii strings in 20M FITS files. So we have to monkeypatch fitsio, since it doesn't support this use case directly
Introduce `dysh online` command for real-time monitoring of GBT SDFITS sessions, with support for: - Auto-discovery of active sessions from sdfitsStatus.txt - Resilient file watching that survives directory/file deletion - Detection scan number regression/decrease - Detection of duplicate scan numbers Add `dysh simulate-online` command for testing online mode by replaying existing SDFITS sessions scan-by-scan with configurable timing. Fix bugs in OnlineGBTFITSLoad: - Set self._online when directory path is provided - Fix mtime loop accumulator bug in _reload() - Add FileNotFoundError for non-existent paths Add unit tests for OnlineGBTFITSLoad covering file growth detection, missing file handling, file recreation, and scan anomaly detection.
Also forgot to track cli.py...
Ensure that we are still caching the file in mem when accessed via astropy Ensure that we are using that cache on subsequent row-level reads via fitsio. i.e. we don't want to hit disk to load 2 rows from the file if they are already available via the hdu in mem
But not clear this is a good idea
for more information, see https://pre-commit.ci
…tory/dysh into 419-switch-to-fitsio-v2
updated doc on that. 2) Rename "PROC" column to "PROCS" because that is the name of the equivalent column in the index file.
for more information, see https://pre-commit.ci
…tory/dysh into 419-switch-to-fitsio-v2
…the smae files as GBTFITSLoad. add -b for FITSBackend
for more information, see https://pre-commit.ci
mpound
approved these changes
Mar 4, 2026
Collaborator
mpound
left a comment
mpound
left a comment
There was a problem hiding this comment.
All comments and concerns of Pedro have been resolved.
for more information, see https://pre-commit.ci
…tory/dysh into 419-switch-to-fitsio-v2
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
- rename load_all_rows to load_all - add test for load_all
…tory/dysh into 419-switch-to-fitsio-v2
for more information, see https://pre-commit.ci
…tory/dysh into 419-switch-to-fitsio-v2
for more information, see https://pre-commit.ci
This was referenced Mar 11, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.