Conversation
Collaborator
Author
|
Code needs a check if it still works if the sig is multiple scans vs. the ref being one scan. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…into 800-getsigref
for more information, see https://pre-commit.ci
…into 800-getsigref
for more information, see https://pre-commit.ci
Collaborator
Author
|
Although checks passed, they are because the in several places the 1e-6 type threshold was increased to 1e-3. This needs to be understood. The patch to compute the exposure time results in individual exposures (per integration) to be accurate to only 0.01 sec (out of 5 sec), but their sum is accurate to 1e-5. |
Collaborator
Author
|
confirmed via the nodding notebook that radiometer is ok there. makes sense, since the exposure equations are effectively a simple getps(). |
…into 800-getsigref
mpound
reviewed
Mar 10, 2026
mpound
reviewed
Mar 10, 2026
mpound
reviewed
Mar 10, 2026
mpound
reviewed
Mar 10, 2026
mpound
approved these changes
Mar 10, 2026
Collaborator
mpound
left a comment
mpound
left a comment
There was a problem hiding this comment.
Nice, thanks. Just deal with my comments and we are good to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During a getsigref() the reference scan gets internally converted to a reference spectrum, and looses the exposure per integration, which is needed for the current way of computing the exposure time in PSScan(). This patch fixes this by artifically creating an exposure array for the ref equal to that of the sig.