forked from GreenBlitz/2025-Offseason
-
Notifications
You must be signed in to change notification settings - Fork 0
turret camera -> master #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DanielShapir
wants to merge
11
commits into
master
Choose a base branch
from
make-limelight-work-with-turret
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
84c209b
changes
DanielShapir 0c6c556
changes
DanielShapir c284265
changes
DanielShapir 63eb10e
changes
DanielShapir 260a254
pls
DanielShapir 106ed02
Merge branch 'master' into make-limelight-work-with-turret
tomer-hershman dcb266c
save before removal of comments
DanielShapir d7b2a87
pls
DanielShapir 0ac6a40
Merge remote-tracking branch 'origin/master' into make-limelight-work…
DanielShapir 16a49c6
back to the past
DanielShapir 452d684
today ive learned how to name func
DanielShapir File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -212,6 +212,17 @@ public List<DetectedObjectObservation> getRobotRelativeColorDetections() { | |
| return new ArrayList<>(); | ||
| } | ||
|
|
||
| public static Pose2d calculateRobotCenterRelativeToField( | ||
| Supplier<Pose2d> limeLightPoseRelativeToRobotCenter, | ||
| Pose2d limeLightPoseRelativeToField | ||
| ) { | ||
| Transform2d camTransformRelativeToRobotCenter = new Transform2d( | ||
| new Pose2d(0, 0, Rotation2d.fromDegrees(0.0)), | ||
| limeLightPoseRelativeToRobotCenter.get() | ||
| ); | ||
| return (limeLightPoseRelativeToField.transformBy(camTransformRelativeToRobotCenter.inverse())); | ||
| } | ||
|
|
||
|
Comment on lines
+215
to
+225
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is the camera only moving in 2d space? |
||
| public Function<LimelightHelpers.RawDetection, Boolean> getNeuralDetectionFilter() { | ||
| return neuralDetectionFilter; | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.