forked from GreenBlitz/2025-Offseason
-
Notifications
You must be signed in to change notification settings - Fork 0
Odometry when tilted -> master #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
DanielShapir
wants to merge
7
commits into
master
Choose a base branch
from
odometry-when-tilted-design
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
23cf233
plssssss
DanielShapir 2f95ef3
changes
DanielShapir 0a1ea6b
plssss i was dumb af
DanielShapir 7b59b90
changes
DanielShapir b4ea190
not finished
DanielShapir 4c71e12
commit
DanielShapir 11bab97
random save
DanielShapir File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| package frc.robot.odometry; | ||
|
|
||
| import edu.wpi.first.math.geometry.Pose2d; | ||
| import edu.wpi.first.math.geometry.Rotation2d; | ||
| import edu.wpi.first.math.geometry.Rotation3d; | ||
| import edu.wpi.first.math.geometry.Transform2d; | ||
| import edu.wpi.first.math.kinematics.Kinematics; | ||
| import edu.wpi.first.math.kinematics.Odometry; | ||
| import java.util.function.Supplier; | ||
|
|
||
| public class OdometryPlus<T> extends Odometry<T> { | ||
|
|
||
| private final Supplier<Rotation3d> robotOrientationSupplier; | ||
|
|
||
| /** | ||
| * Constructs a 2d odometry object that takes into consideration the robot's 3d orientation. | ||
| * | ||
| * @param kinematics The kinematics of the chassis. | ||
| * @param gyroAngle The given robot's yaw. | ||
| * @param wheelPositions The current wheel positions. | ||
| * @param initialPoseMeters The starting position of the robot on the field. | ||
| */ | ||
| public OdometryPlus(Kinematics<?, T> kinematics, Rotation2d gyroAngle, T wheelPositions, Pose2d initialPoseMeters) { | ||
| super(kinematics, gyroAngle, wheelPositions, initialPoseMeters); | ||
| this.robotOrientationSupplier = () -> new Rotation3d(0, 0, this.getHeading().getRadians()); | ||
| } | ||
|
|
||
| public OdometryPlus( | ||
| Kinematics<?, T> kinematics, | ||
| Rotation2d gyroAngle, | ||
| T wheelPositions, | ||
| Pose2d initialPoseMeters, | ||
| Supplier<Rotation3d> robotOrientationSupplier | ||
| ) { | ||
| super(kinematics, gyroAngle, wheelPositions, initialPoseMeters); | ||
| this.robotOrientationSupplier = robotOrientationSupplier; | ||
| } | ||
|
|
||
| @Override | ||
| public Pose2d update(Rotation2d gyroAngle, T wheelPositions) { | ||
| Pose2d lastPose = getPoseMeters(); | ||
| Pose2d unCompensatedPose = super.update(gyroAngle, wheelPositions); | ||
|
|
||
| if (robotOrientationSupplier == null) | ||
| return unCompensatedPose; | ||
| Rotation3d robotOrientation = robotOrientationSupplier.get(); | ||
| double scale = Math.cos(robotOrientation.rotateBy(new Rotation3d(0, 0, -robotOrientation.getZ())).getY()); | ||
| Transform2d unCompensatedDistance = new Transform2d(lastPose, unCompensatedPose); | ||
|
|
||
| Pose2d compensatedByPitch = lastPose | ||
| .plus(new Transform2d(unCompensatedDistance.getTranslation().times(scale), unCompensatedDistance.getRotation())); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. consider just doing |
||
|
|
||
| resetTranslation(compensatedByPitch.getTranslation()); | ||
|
|
||
| return compensatedByPitch; | ||
| } | ||
|
|
||
| public Rotation2d getHeading() { | ||
| return this.getPoseMeters().getRotation(); | ||
| } | ||
|
|
||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why check if null?
Why not check if everything else is null?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
outdated
already changed the whole thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have no time to update it right now