Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
FluidIngredient::toJson had code to output either a single value, or an array of values, depending on what's in FluidIngredient.values. However, a missing
elsemeans it would always output an array.Implementation Details
Put the array code inside an
elseOutcome
Output json is a single value or an array as expected
How Was This Tested
Game compiles and runs
Additional Information
The fromJson already correctly handles the two cases
Potential Compatibility Issues
If any external code uses FluidIngredient::toJson and always expects an array, this change would break their code.
An alternative to this PR would be to explicitly always return an array.