fix(gui): match patched card subtitle to base cards#28
Merged
Conversation
GregTheGreek
marked this pull request as ready for review
July 6, 2026 10:04
The patched ROM card subtitle rendered a long "based on <title>" line that WKWebView failed to clip inside the grid, spilling text across neighboring cards. Use the same system + size metadata line as base ROM cards so it stays short and consistent. Co-Authored-By: Claude
GregTheGreek
force-pushed
the
fix/patched-card-text-clip
branch
from
July 6, 2026 10:14
b4ac99b to
343539e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Patched ROM grid cards showed a long
based on <title>subtitle that WKWebView wouldn't clip inside the grid, so the text spilled across neighboring cards. Swap it for the samesystem · sizemetadata line the base ROM cards use - short, consistent, no overflow. Renders correctly in Chromium and WKWebView.Test plan
GBA · <size>matching base cards, no text overflow